You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@oozie.apache.org by Artem Ervits <db...@gmail.com> on 2017/11/07 15:19:45 UTC
Review Request 63626: OOZIE-3001 core library has many instances of
warnings with trailing spaces and lines longer than 132 chars
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63626/
-----------------------------------------------------------
Review request for oozie and András Piros.
Repository: oozie-git
Description
-------
OOZIE-3001 core library has many instances of warnings with trailing spaces and lines longer than 132 chars
Diffs
-----
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java d9417535
core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java 52abbf17
core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java 22b6dc9f
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 23e1f69e
core/src/main/java/org/apache/oozie/command/bundle/BundleJobException.java 05e526ed
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 2e3671df
core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1516ec32
Diff: https://reviews.apache.org/r/63626/diff/1/
Testing
-------
yes
Thanks,
Artem Ervits
Re: Review Request 63626: OOZIE-3001 core library has many instances
of warnings with trailing spaces and lines longer than 132 chars
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63626/#review190460
-----------------------------------------------------------
Ship it!
Ship It!
- András Piros
On Nov. 8, 2017, 2:53 p.m., Artem Ervits wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63626/
> -----------------------------------------------------------
>
> (Updated Nov. 8, 2017, 2:53 p.m.)
>
>
> Review request for oozie and András Piros.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3001 core library has many instances of warnings with trailing spaces and lines longer than 132 chars
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java d9417535
> core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java 47b2407d
> core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java bc87f294
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 6a25e5c8
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobException.java 05e526ed
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 2e3671df
> core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1516ec32
>
>
> Diff: https://reviews.apache.org/r/63626/diff/2/
>
>
> Testing
> -------
>
> yes
>
>
> File Attachments
> ----------------
>
> new patch
> https://reviews.apache.org/media/uploaded/files/2017/11/08/48daa130-a49c-4348-9fd0-48268a4e2977__OOZIE-3001-3.patch
>
>
> Thanks,
>
> Artem Ervits
>
>
Re: Review Request 63626: OOZIE-3001 core library has many instances
of warnings with trailing spaces and lines longer than 132 chars
Posted by Artem Ervits <db...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63626/
-----------------------------------------------------------
(Updated Nov. 8, 2017, 2:53 p.m.)
Review request for oozie and András Piros.
Repository: oozie-git
Description
-------
OOZIE-3001 core library has many instances of warnings with trailing spaces and lines longer than 132 chars
Diffs (updated)
-----
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java d9417535
core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java 47b2407d
core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java bc87f294
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 6a25e5c8
core/src/main/java/org/apache/oozie/command/bundle/BundleJobException.java 05e526ed
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 2e3671df
core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1516ec32
Diff: https://reviews.apache.org/r/63626/diff/2/
Changes: https://reviews.apache.org/r/63626/diff/1-2/
Testing
-------
yes
File Attachments
----------------
new patch
https://reviews.apache.org/media/uploaded/files/2017/11/08/48daa130-a49c-4348-9fd0-48268a4e2977__OOZIE-3001-3.patch
Thanks,
Artem Ervits
Re: Review Request 63626: OOZIE-3001 core library has many instances
of warnings with trailing spaces and lines longer than 132 chars
Posted by Artem Ervits <db...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63626/
-----------------------------------------------------------
(Updated Nov. 8, 2017, 2:52 p.m.)
Review request for oozie and András Piros.
Repository: oozie-git
Description
-------
OOZIE-3001 core library has many instances of warnings with trailing spaces and lines longer than 132 chars
Diffs
-----
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java d9417535
core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java 52abbf17
core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java 22b6dc9f
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 23e1f69e
core/src/main/java/org/apache/oozie/command/bundle/BundleJobException.java 05e526ed
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 2e3671df
core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1516ec32
Diff: https://reviews.apache.org/r/63626/diff/1/
Testing
-------
yes
File Attachments (updated)
----------------
new patch
https://reviews.apache.org/media/uploaded/files/2017/11/08/48daa130-a49c-4348-9fd0-48268a4e2977__OOZIE-3001-3.patch
Thanks,
Artem Ervits
Re: Review Request 63626: OOZIE-3001 core library has many instances
of warnings with trailing spaces and lines longer than 132 chars
Posted by András Piros via Review Board <no...@reviews.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/63626/#review190341
-----------------------------------------------------------
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
Lines 220 (patched)
<https://reviews.apache.org/r/63626/#comment267647>
Incorrect number of white spaces. Should be 8 more than previous line.
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
Lines 223 (patched)
<https://reviews.apache.org/r/63626/#comment267648>
Incorrect number of white spaces. Should be 8 more than previous line.
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
Lines 298 (patched)
<https://reviews.apache.org/r/63626/#comment267649>
Incorrect number of white spaces. Should be 8 more than previous line.
core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java
Lines 301 (patched)
<https://reviews.apache.org/r/63626/#comment267650>
Incorrect number of white spaces. Should be 8 more than previous line.
core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java
Lines 667 (patched)
<https://reviews.apache.org/r/63626/#comment267651>
Incorrect number of white spaces. Should be 8 more than previous line.
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java
Lines 69-70 (patched)
<https://reviews.apache.org/r/63626/#comment267652>
Incorrect number of white spaces. Should be 8 more than previous line.
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java
Lines 126 (patched)
<https://reviews.apache.org/r/63626/#comment267653>
Incorrect number of white spaces. Should be 8 more than previous line.
core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java
Lines 186 (patched)
<https://reviews.apache.org/r/63626/#comment267654>
Incorrect number of white spaces. Should be 8 more than previous line.
core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java
Lines 109-110 (original), 111-113 (patched)
<https://reviews.apache.org/r/63626/#comment267655>
Each parameter on new line would be more readable.
- András Piros
On Nov. 7, 2017, 3:19 p.m., Artem Ervits wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/63626/
> -----------------------------------------------------------
>
> (Updated Nov. 7, 2017, 3:19 p.m.)
>
>
> Review request for oozie and András Piros.
>
>
> Repository: oozie-git
>
>
> Description
> -------
>
> OOZIE-3001 core library has many instances of warnings with trailing spaces and lines longer than 132 chars
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/oozie/action/email/EmailActionExecutor.java d9417535
> core/src/main/java/org/apache/oozie/action/hadoop/HCatCredentials.java 52abbf17
> core/src/main/java/org/apache/oozie/action/hadoop/HbaseCredentials.java 22b6dc9f
> core/src/main/java/org/apache/oozie/action/hadoop/JavaActionExecutor.java 23e1f69e
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobException.java 05e526ed
> core/src/main/java/org/apache/oozie/command/bundle/BundleJobResumeXCommand.java 2e3671df
> core/src/main/java/org/apache/oozie/command/bundle/BundleKillXCommand.java 1516ec32
>
>
> Diff: https://reviews.apache.org/r/63626/diff/1/
>
>
> Testing
> -------
>
> yes
>
>
> Thanks,
>
> Artem Ervits
>
>