You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hc.apache.org by "Bryan Pon (JIRA)" <ji...@apache.org> on 2010/12/10 21:02:03 UTC
[jira] Closed: (HTTPCORE-246) ThrottlingHttpClientHandler triggers
EventListener.connectionClosed twice
[ https://issues.apache.org/jira/browse/HTTPCORE-246?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Bryan Pon closed HTTPCORE-246.
------------------------------
Looks good to me. And thanks for the tip - I'll change my logic to utilize finalizeContext instead.
> ThrottlingHttpClientHandler triggers EventListener.connectionClosed twice
> -------------------------------------------------------------------------
>
> Key: HTTPCORE-246
> URL: https://issues.apache.org/jira/browse/HTTPCORE-246
> Project: HttpComponents HttpCore
> Issue Type: Bug
> Components: HttpCore NIO
> Affects Versions: 4.1
> Environment: Linux 2.6.32-26-generic #47-Ubuntu
> Reporter: Bryan Pon
> Priority: Minor
> Fix For: 4.1.1
>
>
> In ThrottlingHttpClientHandler.closed(NHttpClientConnection), connectionClosed() is called twice on the event listener:
> if (this.eventListener != null) {
> this.eventListener.connectionClosed(conn);
> }
> this.execHandler.finalizeContext(context);
> if (this.eventListener != null) {
> this.eventListener.connectionClosed(conn);
> }
> I'm not sure if this is intentional (looks unlikely), but I have a use case where this causes problems. I want to start a new connection whenever one is closed, so in the EventListener.connectionClosed() method I am invoking ConnectingIOReactor.connect(). Since connectionClosed() is triggered twice, this is opening two new connections. I can work around the issue by checking if connectionClosed() has already been called.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@hc.apache.org
For additional commands, e-mail: dev-help@hc.apache.org