You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@lucene.apache.org by rm...@apache.org on 2022/11/25 16:52:43 UTC
[lucene] 02/04: fix use of wrong array equals() method in test, enable check (#11977)
This is an automated email from the ASF dual-hosted git repository.
rmuir pushed a commit to branch branch_9x
in repository https://gitbox.apache.org/repos/asf/lucene.git
commit 2f74ac46e830f6325c0a7f4bc461ce67834d61bf
Author: Robert Muir <rm...@apache.org>
AuthorDate: Fri Nov 25 11:46:48 2022 -0500
fix use of wrong array equals() method in test, enable check (#11977)
---
gradle/validation/error-prone.gradle | 2 +-
.../org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java | 3 ++-
2 files changed, 3 insertions(+), 2 deletions(-)
diff --git a/gradle/validation/error-prone.gradle b/gradle/validation/error-prone.gradle
index bdf6701bc3b..294a824c83b 100644
--- a/gradle/validation/error-prone.gradle
+++ b/gradle/validation/error-prone.gradle
@@ -78,7 +78,7 @@ allprojects { prj ->
'-Xep:AlwaysThrows:ERROR',
'-Xep:AndroidInjectionBeforeSuper:ERROR',
- // '-Xep:ArrayEquals:OFF',
+ '-Xep:ArrayEquals:ERROR',
'-Xep:ArrayFillIncompatibleType:ERROR',
// '-Xep:ArrayHashCode:OFF',
// '-Xep:ArrayToString:OFF',
diff --git a/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java b/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java
index b0a3e35348a..1eb80ea5081 100644
--- a/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java
+++ b/lucene/analysis/common/src/test/org/apache/lucene/analysis/synonym/TestSynonymGraphFilter.java
@@ -21,6 +21,7 @@ import java.io.IOException;
import java.io.StringReader;
import java.text.ParseException;
import java.util.ArrayList;
+import java.util.Arrays;
import java.util.HashSet;
import java.util.List;
import java.util.Locale;
@@ -1401,7 +1402,7 @@ public class TestSynonymGraphFilter extends BaseTokenStreamTestCase {
for (int j = 0; j < synCount; j++) {
OneSyn syn2 = syns.get(i);
keepOrig |= syn2.keepOrig;
- if (syn1.in.equals(syn2.in)) {
+ if (Arrays.equals(syn1.in, syn2.in)) {
count += syn2.out.length;
}
}