You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@airflow.apache.org by GitBox <gi...@apache.org> on 2020/12/29 16:43:21 UTC

[GitHub] [airflow] oost opened a new issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

oost opened a new issue #13367:
URL: https://github.com/apache/airflow/issues/13367


   **Apache Airflow version**: apache-airflow-upgrade-check 1.1.0
   
   
   **Environment**:
   
   - **Cloud provider or hardware configuration**: N/A
   - **OS** (e.g. from /etc/os-release): N/A
   - **Kernel** (e.g. `uname -a`): N/A
   - **Install tools**: pip
   - **Others**: N/A
   
   **What happened**:
   
   Content of the two files on [pypi](https://pypi.org/project/apache-airflow-upgrade-check/#files) is different. The tar file contains the code from tag upgrade-check/1.1.0 but it seems the wheel file contains code from tag upgrade-check/1.0.0. For example, the rule invalid_kubernetes_configs.py is present in the wheel file while absent in the [repo at the 1.1.0 tag](https://github.com/apache/airflow/tree/upgrade-check/1.1.0/airflow/upgrade/rules) as well as in the tar file on pypi. 
   
   Am I missing something? 
   
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] oost closed issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

oost closed issue #13367:
URL: https://github.com/apache/airflow/issues/13367


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

potiuk edited a comment on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-752248717

I confirm that the two packages have different content but I think it was some accidental problem while preparing the .whl package.

I compared the contents and checked also the sources in the official ASF SVN: https://archive.apache.org/dist/airflow/upgrade-check/1.1.0/ and it seems that the extra file you mentioned `invalid_kubernetes_configs.py` is the ONLY difference between the packages. All the rest is as-expected and matches the 1.1.0 tag.

My guess is that the .whl file was first wrongly prepared - it was built first using the 1.0.0 label and then re-created with 1.1.0 which would explain why the file is there.

Does it cause any problems for you @oost? Does it fail the rule or causes some other problems?

Just in case - You know that you can also disable some rules by configuration as a workaround:

https://pypi.org/project/apache-airflow-upgrade-check/

```
airflow upgrade_check --config=/files/upgrade.yaml
```

the configuration file should be a proper yaml file similar to this one:

```
ignored_rules:
- InvalidKubernetesConfigRule
```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] oost commented on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

oost commented on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-752249735


   Thanks. That works. 
   
   Yes, I have been using a config file to ignore rules but couldn't find which rule to ignore as it was not there in the 1.1.0 tag. This will do. 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil closed issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

kaxil closed issue #13367:
URL: https://github.com/apache/airflow/issues/13367


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-755603307


   Reopened to make sure we check it when we release next time


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

potiuk edited a comment on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-752248717

I confirm that the two pakcages have different content but I think it was some accidental problem while preparing the .whl package.
I compared the contents and checkd also the sources in the official ASF SVN: https://archive.apache.org/dist/airflow/upgrade-check/1.1.0/ and it seems that the extra file you mentioned `invalid_kubernetes_configs.py` is the ONLY difference between the packages. All the rest is as-expected and matches the 1.1.0 tag.

My guess is that the whl file was first wrongly prepared - it was built first using the 1.0.0 label and then re-created with 1.1.0 which would explain why the file is there.

Does it cause any problems for you? Does it fail the rule or causes some other problems?

Just in case - You know that you can also disable some rules by configuration as a workaround:

https://pypi.org/project/apache-airflow-upgrade-check/

```
airflow upgrade_check --config=/files/upgrade.yaml
```

the configuration file should be a proper yaml file similar to this one:

```
ignored_rules:
- InvalidKubernetesConfigRule
```

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk edited a comment on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

potiuk edited a comment on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-752248717

I confirm that the two packages have different content but I think it was some accidental problem while preparing the .whl package.

My guess is that the .whl file was first wrongly prepared - it was built first using the 1.0.0 label and then re-created with 1.1.0 which would explain why the file is there.

Does it cause any problems for you? Does it fail the rule or causes some other problems?

Just in case - You know that you can also disable some rules by configuration as a workaround:

https://pypi.org/project/apache-airflow-upgrade-check/

```
airflow upgrade_check --config=/files/upgrade.yaml
```

the configuration file should be a proper yaml file similar to this one:

```
ignored_rules:
- InvalidKubernetesConfigRule
```

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] kaxil commented on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

kaxil commented on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-780554065


   Fixed in apache-airflow-upgrade-check 1.2.0 
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-752248717

I confirm that the two files are different but I think it was some accidental problem while preparing the .whl package.
I compared the contents and checkd also the sources in the official ASF SVN: https://archive.apache.org/dist/airflow/upgrade-check/1.1.0/ and it seems that the extra file you mentioned `invalid_kubernetes_configs.py` is the ONLY difference between the packages. All the rest is as-expected and matches the 1.1.0 tag.

My guess is that the whl file was first wrongly prepared - it was built first using the 1.0.0 label and then re-created with 1.1.0 which would explain why the file is there.

Does it cause any problems for you? Does it fail the rule or causes some other problems?

Just in case - You know that you can also disable some rules by configuration as a workaround:

https://pypi.org/project/apache-airflow-upgrade-check/

```
airflow upgrade_check --config=/files/upgrade.yaml
```

the configuration file should be a proper yaml file similar to this one:

```
ignored_rules:
- InvalidKubernetesConfigRule
```

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] boring-cyborg[bot] commented on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

boring-cyborg[bot] commented on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-752152730


   Thanks for opening your first issue here! Be sure to follow the issue template!
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

[GitHub] [airflow] potiuk commented on issue #13367: Pypi wheel package for apache-airflow-upgrade-check 1.1.0 is wrong

Posted by GitBox <gi...@apache.org>.

potiuk commented on issue #13367:
URL: https://github.com/apache/airflow/issues/13367#issuecomment-752249263


   cc: @kaxil @ashb -> I guess something to pay attention to with 1.2.0 release. I am not sure if my guess was ok, or whether there was some other reason for the accidental inclusion.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org