[GitHub] [spark] dnskr edited a comment on pull request #35234: [SPARK-32165][SQL] SessionState leaks SparkListener with multiple SparkSession

[GitBox <gi...@apache.org>]

dnskr edited a comment on pull request #35234:
URL: https://github.com/apache/spark/pull/35234#issuecomment-1016413745


   @cloud-fan Thanks for the question.
   I checked memory dumps and I didn't find that multiple `SharedStates` are instantiated in the Spark Thrift Server.
   It are only one instance of `SharedState` and only one instance of `SQLAppStatusListener`.
   So I can conclude that this is not a reason of memory leak in my case.
   
   However unit tests in the PR and jira ticket demonstrate potential memory leak, so:
    - Should we fix it even though it doesn't happen in real scenario (there is always only one `SharedState` instance per driver JVM)?
    - Should we just close the original jira ticket with proper status/comment to avoid misunderstanding in the future? I'm asking because I found the ticket by searching "leak" in jira to find why I have the memory leak issue.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org