You are viewing a plain text version of this content. The canonical link for it is here.

Posted to dev@flume.apache.org by Tristan Stevens <tr...@cloudera.com> on 2017/06/26 18:43:54 UTC

Re: Review Request 52279: FLUME-2917 Provide netcat UDP source as alternative to TCP

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/52279/
-----------------------------------------------------------

(Updated June 26, 2017, 6:43 p.m.)


Review request for Flume and Balázs Donát Bessenyei.


Changes
-------

Fix final defect


Repository: flume-git


Description
-------

Implementation is heavily based on the existing SyslogUDPSource - the tests and implementation mirror that. We could consider making it a superclass of SyslogUDPSource and removing the syslog parsing, if this was felt tidier.


Diffs (updated)
-----

  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceConfiguration.java 6bd14896 
  flume-ng-configuration/src/main/java/org/apache/flume/conf/source/SourceType.java 4f4073a6 
  flume-ng-core/src/main/java/org/apache/flume/source/NetcatUdpSource.java PRE-CREATION 
  flume-ng-core/src/test/java/org/apache/flume/source/TestDefaultSourceFactory.java baa85003 
  flume-ng-core/src/test/java/org/apache/flume/source/TestNetcatUdpSource.java PRE-CREATION 
  flume-ng-doc/sphinx/FlumeUserGuide.rst 2073bf63 


Diff: https://reviews.apache.org/r/52279/diff/7/

Changes: https://reviews.apache.org/r/52279/diff/6-7/


Testing
-------

Unit tests provided.


Thanks,

Tristan Stevens