[GitHub] [flink] godfreyhe commented on a change in pull request #14451: [FLINK-20704][table-planner] Some rel data type does not implement th…

[GitBox <gi...@apache.org>]

godfreyhe commented on a change in pull request #14451:
URL: https://github.com/apache/flink/pull/14451#discussion_r547266514



##########
File path: flink-table/flink-table-planner/src/test/scala/org/apache/flink/table/calcite/FlinkTypeFactoryTest.scala
##########
@@ -0,0 +1,47 @@
+package org.apache.flink.table.calcite
+
+import org.apache.flink.api.scala.typeutils.Types
+
+import org.apache.calcite.sql.`type`.SqlTypeName
+import org.junit.Assert.{assertFalse, assertTrue}
+import org.junit.Test
+
+/** Test cases for [[FlinkTypeFactory]]. */
+class FlinkTypeFactoryTest {
+
+  @Test
+  def testCanonizeType(): Unit = {

Review comment:
       I find the test does not cover the changes. I revert the changes and run the method, all tests are success. 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org