svn commit: rev 10705 - incubator/spamassassin/trunk/spamd

[ms...@apache.org]

Author: mss
Date: Mon May 17 15:35:00 2004
New Revision: 10705

Modified:
   incubator/spamassassin/trunk/spamd/spamd.raw
Log:
bug 3354: the local[0-9] syslog facilities didn't work because [0-9] are non-word characters (?)


Modified: incubator/spamassassin/trunk/spamd/spamd.raw
==============================================================================
--- incubator/spamassassin/trunk/spamd/spamd.raw	(original)
+++ incubator/spamassassin/trunk/spamd/spamd.raw	Mon May 17 15:35:00 2004
@@ -292,7 +292,7 @@
 my $log_file = "spamd.log";
 
 # A specific log file was given (--syslog=/path/to/file).
-if ( $log_facility =~ /\W/ ) {
+if ( $log_facility =~ /[^a-z0-9]/ ) {
   $log_file   = $log_facility;
   $log_socket = 'file';
 }

Re: svn commit: rev 10705 - incubator/spamassassin/trunk/spamd

["Malte S. Stretz" <ms...@gmx.net>]

On Tuesday 18 May 2004 04:55 CET Theo Van Dinter wrote:
> On Mon, May 17, 2004 at 10:35:02PM -0000, mss@apache.org wrote:
> > bug 3354: the local[0-9] syslog facilities didn't work because [0-9]
> > are non-word characters (?) -if ( $log_facility =~ /\W/ ) {
> > +if ( $log_facility =~ /[^a-z0-9]/ ) {
>
> I think there's something else going on.  0-9 is 100% definitely in \w,
> and so, consequently, definitely won't trigger \W.

Yeah, for some reason it only didn't work for the local* stuff for me but in 
the it looks like I got just bitten by metalog's async logging :-(

The bug I went to fix was actually a dup, I hope the patch from the other 
one fixed it.

Cheers,
Malte

-- 
[SGT] Simon G. Tatham: "How to Report Bugs Effectively"
      <http://www.chiark.greenend.org.uk/~sgtatham/bugs.html>
[ESR] Eric S. Raymond: "How To Ask Questions The Smart Way"
      <http://www.catb.org/~esr/faqs/smart-questions.html>

Re: svn commit: rev 10705 - incubator/spamassassin/trunk/spamd

[Theo Van Dinter <fe...@kluge.net>]

On Mon, May 17, 2004 at 10:35:02PM -0000, mss@apache.org wrote:
> bug 3354: the local[0-9] syslog facilities didn't work because [0-9] are non-word characters (?)
> -if ( $log_facility =~ /\W/ ) {
> +if ( $log_facility =~ /[^a-z0-9]/ ) {

I think there's something else going on.  0-9 is 100% definitely in \w,
and so, consequently, definitely won't trigger \W.

-- 
Randomly Generated Tagline:
"I can't remember what television was like before TiVo. It takes all
 the worry out of keeping up with my favorite shows and often surprises
 me with a game I didn't know about. TiVo is the Royale with cheese of
 the new millennium!"                    - Samuel L. Jackson