You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jclouds.apache.org by ga...@apache.org on 2015/12/12 01:56:44 UTC
[2/3] jclouds git commit: Remove @Nullable from methods returning
primitives
Remove @Nullable from methods returning primitives
Found via error-prone.
Project: http://git-wip-us.apache.org/repos/asf/jclouds/repo
Commit: http://git-wip-us.apache.org/repos/asf/jclouds/commit/06e379d7
Tree: http://git-wip-us.apache.org/repos/asf/jclouds/tree/06e379d7
Diff: http://git-wip-us.apache.org/repos/asf/jclouds/diff/06e379d7
Branch: refs/heads/master
Commit: 06e379d7a5f70f1ead9bb3eed49e245a7f717982
Parents: 75e2c69
Author: Andrew Gaul <ga...@apache.org>
Authored: Sat Dec 12 08:07:34 2015 +0800
Committer: Andrew Gaul <ga...@apache.org>
Committed: Sat Dec 12 08:53:07 2015 +0800
----------------------------------------------------------------------
.../java/org/jclouds/cloudwatch/domain/StatisticValues.java | 6 ------
project/pom.xml | 1 +
.../org/jclouds/googlecomputeengine/domain/BackendService.java | 4 ++--
.../java/org/jclouds/googlecomputeengine/domain/Instance.java | 2 +-
.../src/main/java/org/jclouds/softlayer/domain/Address.java | 3 ---
.../main/java/org/jclouds/softlayer/domain/VirtualGuest.java | 1 -
6 files changed, 4 insertions(+), 13 deletions(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/jclouds/blob/06e379d7/apis/cloudwatch/src/main/java/org/jclouds/cloudwatch/domain/StatisticValues.java
----------------------------------------------------------------------
diff --git a/apis/cloudwatch/src/main/java/org/jclouds/cloudwatch/domain/StatisticValues.java b/apis/cloudwatch/src/main/java/org/jclouds/cloudwatch/domain/StatisticValues.java
index ee23b52..80bb0c4 100644
--- a/apis/cloudwatch/src/main/java/org/jclouds/cloudwatch/domain/StatisticValues.java
+++ b/apis/cloudwatch/src/main/java/org/jclouds/cloudwatch/domain/StatisticValues.java
@@ -16,8 +16,6 @@
*/
package org.jclouds.cloudwatch.domain;
-import org.jclouds.javax.annotation.Nullable;
-
/**
* @see <a href="http://docs.amazonwebservices.com/AmazonCloudWatch/latest/APIReference/API_StatisticSet.html" />
*/
@@ -38,7 +36,6 @@ public class StatisticValues {
/**
* return the maximum value of the sample set
*/
- @Nullable
public double getMaximum() {
return maximum;
}
@@ -46,7 +43,6 @@ public class StatisticValues {
/**
* return the minimum value of the sample set
*/
- @Nullable
public double getMinimum() {
return minimum;
}
@@ -54,7 +50,6 @@ public class StatisticValues {
/**
* return the number of samples used for the statistic set
*/
- @Nullable
public double getSampleCount() {
return sampleCount;
}
@@ -62,7 +57,6 @@ public class StatisticValues {
/**
* return the sum of values for the sample set
*/
- @Nullable
public double getSum() {
return sum;
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/06e379d7/project/pom.xml
----------------------------------------------------------------------
diff --git a/project/pom.xml b/project/pom.xml
index 77d4083..013ebfc 100644
--- a/project/pom.xml
+++ b/project/pom.xml
@@ -749,6 +749,7 @@
<compilerArg>-Xep:GuiceAssistedInjectScoping:OFF</compilerArg>
<compilerArg>-Xep:LongLiteralLowerCaseSuffix:OFF</compilerArg>
<compilerArg>-Xep:NonAtomicVolatileUpdate:OFF</compilerArg>
+ <compilerArg>-Xep:NullablePrimitive:ERROR</compilerArg>
<compilerArg>-Xep:StringEquality:ERROR</compilerArg>
<compilerArg>-Xep:TypeParameterUnusedInFormals:OFF</compilerArg>
</compilerArgs>
http://git-wip-us.apache.org/repos/asf/jclouds/blob/06e379d7/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/BackendService.java
----------------------------------------------------------------------
diff --git a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/BackendService.java b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/BackendService.java
index f4b15c2..f6e5c7f 100644
--- a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/BackendService.java
+++ b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/BackendService.java
@@ -72,8 +72,8 @@ public abstract class BackendService {
@Nullable public abstract String description();
@Nullable public abstract List<Backend> backends();
@Nullable public abstract List<URI> healthChecks();
- @Nullable public abstract int timeoutSec();
- @Nullable public abstract int port();
+ public abstract int timeoutSec();
+ public abstract int port();
@Nullable public abstract String protocol();
@Nullable public abstract String fingerprint();
@Nullable public abstract String portName();
http://git-wip-us.apache.org/repos/asf/jclouds/blob/06e379d7/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java
----------------------------------------------------------------------
diff --git a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java
index 5ae8f53..957f5dc 100644
--- a/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java
+++ b/providers/google-compute-engine/src/main/java/org/jclouds/googlecomputeengine/domain/Instance.java
@@ -46,7 +46,7 @@ public abstract class Instance {
}
/** A zero-based index to assign to this disk, where 0 is reserved for the boot disk. */
- @Nullable public abstract int index();
+ public abstract int index();
public abstract Type type();
http://git-wip-us.apache.org/repos/asf/jclouds/blob/06e379d7/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Address.java
----------------------------------------------------------------------
diff --git a/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Address.java b/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Address.java
index b3effea..57471b9 100644
--- a/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Address.java
+++ b/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/Address.java
@@ -238,7 +238,6 @@ public class Address {
/**
* @return The id of the account.
*/
- @Nullable
public int getAccountId() {
return accountId;
}
@@ -270,7 +269,6 @@ public class Address {
/**
* @return The name of the contact.
*/
- @Nullable
public int isActive() {
return isActive;
}
@@ -278,7 +276,6 @@ public class Address {
/**
* @return The id of the location.
*/
- @Nullable
public int getLocationId() {
return locationId;
}
http://git-wip-us.apache.org/repos/asf/jclouds/blob/06e379d7/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/VirtualGuest.java
----------------------------------------------------------------------
diff --git a/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/VirtualGuest.java b/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/VirtualGuest.java
index 9b2e596..66f99a6 100644
--- a/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/VirtualGuest.java
+++ b/providers/softlayer/src/main/java/org/jclouds/softlayer/domain/VirtualGuest.java
@@ -789,7 +789,6 @@ public class VirtualGuest {
return this.powerState;
}
- @Nullable
public int getActiveTransactionCount() {
return activeTransactionCount;
}