[GitHub] [hudi] zhuanshenbsj1 commented on a diff in pull request #9038: [HUDI-6423] Incremental cleaning should consider inflight compaction instant

["zhuanshenbsj1 (via GitHub)" <gi...@apache.org>]

zhuanshenbsj1 commented on code in PR #9038:
URL: https://github.com/apache/hudi/pull/9038#discussion_r1238713840


##########
hudi-client/hudi-client-common/src/main/java/org/apache/hudi/table/action/clean/CleanPlanner.java:
##########
@@ -509,7 +509,7 @@ public Pair<Boolean, List<CleanFileInfo>> getDeletePaths(String partitionPath) {
    */
   public Option<HoodieInstant> getEarliestCommitToRetain() {
     return CleanerUtils.getEarliestCommitToRetain(
-        hoodieTable.getMetaClient().getActiveTimeline().getCommitsTimeline(),
+        hoodieTable.getMetaClient().getActiveTimeline().getCommitsAndMergesTimeline(),

Review Comment:
   Previously, there was no consideration of inflight compaction instant. When partitioning by time, if the inflight compaction instant is in the previous partition and is skipped for incremental cleaning, it will cause the log file not be cleaned up.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@hudi.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org