You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@dolphinscheduler.apache.org by GitBox <gi...@apache.org> on 2022/11/09 03:08:11 UTC

[GitHub] [dolphinscheduler] caishunfeng commented on a diff in pull request #12689: [fix-12687]when timeout_notify_strategy is null, modify timeout_notify_strategy

caishunfeng commented on code in PR #12689:
URL: https://github.com/apache/dolphinscheduler/pull/12689#discussion_r1017364985


##########
dolphinscheduler-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java:
##########
@@ -716,8 +717,12 @@ private TaskDefinitionLog updateTask(User loginUser, long projectCode, long task
         }
         TaskDefinitionLog taskDefinitionToUpdate =
                 JSONUtils.parseObject(taskDefinitionJsonObj, TaskDefinitionLog.class);
+        if (TimeoutFlag.CLOSE == taskDefinition.getTimeoutFlag()) {
+            taskDefinition.setTimeoutNotifyStrategy(null);

Review Comment:
   This field is enum type, will it error if null? Please take a check.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@dolphinscheduler.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org