You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Avinash sridharan <av...@mesosphere.io> on 2016/02/14 17:38:51 UTC

Review Request 43566: Modified `NetClsIsolatorTest` to use `ComposingContainerizer`.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43566/
-----------------------------------------------------------

Review request for mesos and Jie Yu.


Bugs: MESOS-4670
    https://issues.apache.org/jira/browse/MESOS-4670


Repository: mesos


Description
-------

This tests the case when both both `docker` and `mesos` containerizers
are specified in the agent flag.


Diffs
-----

  src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660 

Diff: https://reviews.apache.org/r/43566/diff/


Testing
-------

make, make check and `sudo make check`.


Thanks,

Avinash sridharan


Re: Review Request 43566: Modified `NetClsIsolatorTest` to use `ComposingContainerizer`.

Posted by Mesos ReviewBot <re...@mesos.apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43566/#review119185
-----------------------------------------------------------



Patch looks great!

Reviews applied: [43564, 43565, 43566]

Passed command: export OS='ubuntu:14.04' CONFIGURATION='--verbose' COMPILER='gcc' ENVIRONMENT='GLOG_v=1 MESOS_VERBOSE=1'; ./support/docker_build.sh

- Mesos ReviewBot


On Feb. 14, 2016, 4:38 p.m., Avinash sridharan wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/43566/
> -----------------------------------------------------------
> 
> (Updated Feb. 14, 2016, 4:38 p.m.)
> 
> 
> Review request for mesos and Jie Yu.
> 
> 
> Bugs: MESOS-4670
>     https://issues.apache.org/jira/browse/MESOS-4670
> 
> 
> Repository: mesos
> 
> 
> Description
> -------
> 
> This tests the case when both both `docker` and `mesos` containerizers
> are specified in the agent flag.
> 
> 
> Diffs
> -----
> 
>   src/tests/containerizer/isolator_tests.cpp 653b037c489072f43e53dec01a811a9249dcd660 
> 
> Diff: https://reviews.apache.org/r/43566/diff/
> 
> 
> Testing
> -------
> 
> make, make check and `sudo make check`.
> 
> 
> Thanks,
> 
> Avinash sridharan
> 
>