[GitHub] [doris] freemandealer commented on a diff in pull request #14325: [fix](Dictionary-codec) heap overflow with in-predicate on nullable columns (#14319)

[GitBox <gi...@apache.org>]

freemandealer commented on code in PR #14325:
URL: https://github.com/apache/doris/pull/14325#discussion_r1033227759


##########
be/src/olap/in_list_predicate.h:
##########
@@ -252,15 +252,19 @@ class InListPredicateBase : public ColumnPredicate {
             auto& nested_col = nullable_col->get_nested_column();
 
             if (_opposite) {
-                return _base_evaluate<true, true>(&nested_col, &null_bitmap, sel, size);
+                return _base_evaluate<true, true>(&nested_col, &null_bitmap, sel, size,
+                                                  column.get_rowset_segment_id());

Review Comment:
   > we can add a override set method to column nullable, and reset those modify on in list predicate.
   
   Your suggestion is preciated and tested, but proved to be failed to make it.
   The set method in the derived class will not be called properfly for the same (unknown for me) reason as describe in the PR meseage. That being said, we can still use overrided get method, but the asymmetric usage of set&get gets nasty somehow.
   
   AFAIK, the current patch might be the clearest & safest solution.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@doris.apache.org
For additional commands, e-mail: commits-help@doris.apache.org