[GitHub] [servicecomb-java-chassis] liubao68 commented on a change in pull request #2509: [SCB-1710] catch the throwable from the scheduled pulling task

[GitBox <gi...@apache.org>]

liubao68 commented on a change in pull request #2509:
URL: https://github.com/apache/servicecomb-java-chassis/pull/2509#discussion_r690110669



##########
File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/AppManager.java
##########
@@ -104,4 +104,11 @@ private void loadStaticMicroserviceVersionFactory() {
     }
     LOGGER.info("staticMicroserviceVersionFactory is {}.", staticMicroserviceVersionFactoryClass);
   }
+
+  public void pullInstances() {

Review comment:
       Do not modify this. It is incomplete. 

##########
File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/consumer/MicroserviceManager.java
##########
@@ -106,4 +106,26 @@ private void onMicroserviceNotExistEvent(MicroserviceNotExistEvent event) {
 
     removeMicroservice(event.getMicroserviceName());
   }
+
+  public void pullInstances() {

Review comment:
       Do not modify this. It is incomplete. 

##########
File path: service-registry/src/main/java/org/apache/servicecomb/serviceregistry/registry/RemoteServiceRegistry.java
##########
@@ -91,7 +89,7 @@ public void run() {
         TimeUnit.SECONDS);
 
     taskPool.scheduleAtFixedRate(
-        () -> eventBus.post(new PeriodicPullEvent()),
+        new SuppressedRunnableWrapper(appManager::pullInstances),

Review comment:
       Do not modify this. It is incomplete. 




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@servicecomb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org