You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ofbiz.apache.org by "Sumit Pandit (JIRA)" <ji...@apache.org> on 2009/08/01 17:31:14 UTC
[jira] Created: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Invoice can be canceled when associated payment is in Confirmed status.
-----------------------------------------------------------------------
Key: OFBIZ-2785
URL: https://issues.apache.org/jira/browse/OFBIZ-2785
Project: OFBiz
Issue Type: Improvement
Components: accounting
Affects Versions: SVN trunk
Reporter: Sumit Pandit
Priority: Minor
Fix For: SVN trunk
What is the issue -
When user is try to cancel an invoice if its associated payment is in status CONFIRMED it throws an error. Reason is that, since service is try to remove associated payment applications and though Payment's status is CONFIRMED therefore it can't and result is an error.
So to fix it I would suggest that if Payment's status is Confirmed then update its status and set it to sent/received so that it allow to remove its applications.
I think it would be a feasible solution since by doing this payment will become in sent/received status and free to apply to any other invoice.
All opinion and comments are much appreciable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Closed: (OFBIZ-2785) Invoice can be canceled when associated
payment is in Confirmed status.
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anil K Patel closed OFBIZ-2785.
-------------------------------
Resolution: Fixed
Patch applied by Ashish. Thanks.
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Assignee: Anil K Patel
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2785.patch, OFBIZ-2785.patch
>
>
> What is the issue -
> When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
> So to fix it I would suggest
> 1) Remove above mentioned business rule from removePaymentApplication service.
> 2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
> 2) Remove Invoice Payment applications.
> On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
> All opinion and comments are much appreciated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Sumit Pandit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12740537#action_12740537 ]
Sumit Pandit commented on OFBIZ-2785:
-------------------------------------
Just for remainder, please review and comment on the patch so that it could be fixed asap.
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2785.patch
>
>
> What is the issue -
> When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
> So to fix it I would suggest
> 1) Remove above mentioned business rule from removePaymentApplication service.
> 2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
> 2) Remove Invoice Payment applications.
> On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
> All opinion and comments are much appreciated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Sumit Pandit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sumit Pandit updated OFBIZ-2785:
--------------------------------
Attachment: OFBIZ-2785.patch
Here is another patch with different approach.
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Assignee: Anil K Patel
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2785.patch, OFBIZ-2785.patch
>
>
> What is the issue -
> When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
> So to fix it I would suggest
> 1) Remove above mentioned business rule from removePaymentApplication service.
> 2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
> 2) Remove Invoice Payment applications.
> On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
> All opinion and comments are much appreciated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anil K Patel reassigned OFBIZ-2785:
-----------------------------------
Assignee: Anil K Patel (was: Ashish Vijaywargiya)
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Assignee: Anil K Patel
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2785.patch, OFBIZ-2785.patch
>
>
> What is the issue -
> When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
> So to fix it I would suggest
> 1) Remove above mentioned business rule from removePaymentApplication service.
> 2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
> 2) Remove Invoice Payment applications.
> On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
> All opinion and comments are much appreciated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anil K Patel updated OFBIZ-2785:
--------------------------------
Description:
What is the issue -
When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
So to fix it I would suggest
1) Remove above mentioned business rule from removePaymentApplication service.
2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
2) Remove Invoice Payment applications.
On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
All opinion and comments are much appreciated.
was:
What is the issue -
When user is try to cancel an invoice if its associated payment is in status CONFIRMED it throws an error. Reason is that, since service is try to remove associated payment applications and though Payment's status is CONFIRMED therefore it can't and result is an error.
So to fix it I would suggest that if Payment's status is Confirmed then update its status and set it to sent/received so that it allow to remove its applications.
I think it would be a feasible solution since by doing this payment will become in sent/received status and free to apply to any other invoice.
All opinion and comments are much appreciable.
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Priority: Minor
> Fix For: SVN trunk
>
>
> What is the issue -
> When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
> So to fix it I would suggest
> 1) Remove above mentioned business rule from removePaymentApplication service.
> 2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
> 2) Remove Invoice Payment applications.
> On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
> All opinion and comments are much appreciated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Anil K Patel reassigned OFBIZ-2785:
-----------------------------------
Assignee: Anil K Patel
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Assignee: Anil K Patel
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2785.patch
>
>
> What is the issue -
> When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
> So to fix it I would suggest
> 1) Remove above mentioned business rule from removePaymentApplication service.
> 2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
> 2) Remove Invoice Payment applications.
> On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
> All opinion and comments are much appreciated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Anil K Patel (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12738005#action_12738005 ]
Anil K Patel commented on OFBIZ-2785:
-------------------------------------
Vince, Thanks for reviewing the task.
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Priority: Minor
> Fix For: SVN trunk
>
>
> What is the issue -
> When user is try to cancel an invoice if its associated payment is in status CONFIRMED it throws an error. Reason is that, since service is try to remove associated payment applications and though Payment's status is CONFIRMED therefore it can't and result is an error.
> So to fix it I would suggest that if Payment's status is Confirmed then update its status and set it to sent/received so that it allow to remove its applications.
> I think it would be a feasible solution since by doing this payment will become in sent/received status and free to apply to any other invoice.
> All opinion and comments are much appreciable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Commented: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Vince Clark (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12737902#action_12737902 ]
Vince Clark commented on OFBIZ-2785:
------------------------------------
I was never sure what "Confirmed" really meant. If you are suggesting that it means the payment has been applied, then I agree with your approach.
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Priority: Minor
> Fix For: SVN trunk
>
>
> What is the issue -
> When user is try to cancel an invoice if its associated payment is in status CONFIRMED it throws an error. Reason is that, since service is try to remove associated payment applications and though Payment's status is CONFIRMED therefore it can't and result is an error.
> So to fix it I would suggest that if Payment's status is Confirmed then update its status and set it to sent/received so that it allow to remove its applications.
> I think it would be a feasible solution since by doing this payment will become in sent/received status and free to apply to any other invoice.
> All opinion and comments are much appreciable.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Assigned: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Ashish Vijaywargiya (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Ashish Vijaywargiya reassigned OFBIZ-2785:
------------------------------------------
Assignee: Ashish Vijaywargiya (was: Anil K Patel)
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Assignee: Ashish Vijaywargiya
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2785.patch, OFBIZ-2785.patch
>
>
> What is the issue -
> When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
> So to fix it I would suggest
> 1) Remove above mentioned business rule from removePaymentApplication service.
> 2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
> 2) Remove Invoice Payment applications.
> On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
> All opinion and comments are much appreciated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
[jira] Updated: (OFBIZ-2785) Invoice can be canceled when
associated payment is in Confirmed status.
Posted by "Sumit Pandit (JIRA)" <ji...@apache.org>.
[ https://issues.apache.org/jira/browse/OFBIZ-2785?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Sumit Pandit updated OFBIZ-2785:
--------------------------------
Attachment: OFBIZ-2785.patch
Here is the patch which would fix this issue, Please have a look at the patch, if it is approved then in next step I will enable "Application" tab at Payment page so that if Status is CONFIRMED and PaymentApplication is null then user may apply this payment to any other Invoice.
> Invoice can be canceled when associated payment is in Confirmed status.
> -----------------------------------------------------------------------
>
> Key: OFBIZ-2785
> URL: https://issues.apache.org/jira/browse/OFBIZ-2785
> Project: OFBiz
> Issue Type: Improvement
> Components: accounting
> Affects Versions: SVN trunk
> Reporter: Sumit Pandit
> Priority: Minor
> Fix For: SVN trunk
>
> Attachments: OFBIZ-2785.patch
>
>
> What is the issue -
> When user try to cancel a Paid invoice (associated payment is in CONFIRMED status) it throws an on attempt to removePaymentApplication. "removePaymentApplication" services enforces business rule that If Payment is in Confirmed status, PaymentApplications cannot be removed.
> So to fix it I would suggest
> 1) Remove above mentioned business rule from removePaymentApplication service.
> 2) Add status valid change for moving, Payment from CONFIRMED status to sent/received.
> 2) Remove Invoice Payment applications.
> On completion of service Payment (Sent/Received status) will be available for applying to any other Invoice.
> All opinion and comments are much appreciated.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.