You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by "Haoyu Zhai (Jira)" <ji...@apache.org> on 2020/11/19 18:40:00 UTC

[jira] [Commented] (LUCENE-9618) Improve IntervalIterator.nextInterval's behavior/documentation/test

    [ https://issues.apache.org/jira/browse/LUCENE-9618?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17235652#comment-17235652 ] 

Haoyu Zhai commented on LUCENE-9618:
------------------------------------

I created a [PR|https://github.com/apache/lucene-solr/pull/2090] with a simple test case to demonstrate the issue mentioned.

> Improve IntervalIterator.nextInterval's behavior/documentation/test
> -------------------------------------------------------------------
>
>                 Key: LUCENE-9618
>                 URL: https://issues.apache.org/jira/browse/LUCENE-9618
>             Project: Lucene - Core
>          Issue Type: Improvement
>          Components: modules/query
>            Reporter: Haoyu Zhai
>            Priority: Minor
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> I'm trying to play around with my own {{IntervalSource}} and found out that {{nextInterval}} method of IntervalIterator will be called sometimes even after {{nextDoc}}/ {{docID}}/ {{advance}} method returns NO_MORE_DOCS.
>  
> After I dug a bit more I found that {{FilteringIntervalIterator.reset}} is calling an inner iterator's {{nextInterval}} regardless of what the result of {{nextDoc}}, and also most (if not all) existing {{IntervalIterator}}'s implementation do considered the case where {{nextInterval}} is called after {{nextDoc}} returns NO_MORE_DOCS.
>  
> We should probably update the javadoc and test if the behavior is necessary. Or we should change the current implementation to avoid this behavior
> original email discussion thread:
> https://markmail.org/message/7itbwk6ts3bo3gdh



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org