[jira] [Commented] (YARN-1813) Better error message for "yarn logs" when permission denied

["Tsuyoshi OZAWA (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/YARN-1813?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13986201#comment-13986201 ] 

Tsuyoshi OZAWA commented on YARN-1813:
--------------------------------------

Thanks for your review, Vinod!

* Added a full-stop to LogsCLIHelpers.PERMISSION_DENIED_MESSAGE.
* Fixed AggregatedLogsBlock to handle permission exception.
* Fixed Formatting.
* TestLogsCLI: renamed refreshSysOutputs to refreshFileStreams().

About AccessControlExceptionFileSystem, I tried to create mock more smartly and found that it's a bit difficult to use mockito in this case because FileContext is final class and we can inject mock class only via configuration property "fs.AbstractFileSystem.*.impl". If AbstraceFileSystem#newInstance() or createFileSystem() are not static method, we can override it, but they are not. Please let me know if you have better idea.

> Better error message for "yarn logs" when permission denied
> -----------------------------------------------------------
>
>                 Key: YARN-1813
>                 URL: https://issues.apache.org/jira/browse/YARN-1813
>             Project: Hadoop YARN
>          Issue Type: Improvement
>    Affects Versions: 2.3.0
>            Reporter: Andrew Wang
>            Assignee: Tsuyoshi OZAWA
>            Priority: Minor
>         Attachments: YARN-1813.1.patch, YARN-1813.2.patch, YARN-1813.2.patch, YARN-1813.3.patch
>
>
> I ran some MR jobs as the "hdfs" user, and then forgot to sudo -u when grabbing the logs. "yarn logs" prints an error message like the following:
> {noformat}
> [andrew.wang@a2402 ~]$ yarn logs -applicationId application_1394482121761_0010
> 14/03/10 16:05:10 INFO client.RMProxy: Connecting to ResourceManager at a2402.halxg.cloudera.com/10.20.212.10:8032
> Logs not available at /tmp/logs/andrew.wang/logs/application_1394482121761_0010
> Log aggregation has not completed or is not enabled.
> {noformat}
> It'd be nicer if it said "Permission denied" or "AccessControlException" or something like that instead, since that's the real issue.



--
This message was sent by Atlassian JIRA
(v6.2#6252)