You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (JIRA)" <ji...@apache.org> on 2018/03/10 11:17:00 UTC
[jira] [Commented] (HIVE-18560) qtests: QTestUtil refactor/split -
QOutProcessor
[ https://issues.apache.org/jira/browse/HIVE-18560?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16394132#comment-16394132 ]
Hive QA commented on HIVE-18560:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 0s{color} | {color:blue} Findbugs executables are not available. {color} |
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 6m 42s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 13s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 17s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 0m 24s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} itests/util: The patch generated 8 new + 101 unchanged - 7 fixed = 109 total (was 108) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 8 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 0m 16s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:red}-1{color} | {color:red} asflicense {color} | {color:red} 0m 12s{color} | {color:red} The patch generated 49 ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 9m 19s{color} | {color:black} {color} |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.36-1+deb8u1 (2016-09-03) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-9588/dev-support/hive-personality.sh |
| git revision | master / 41afa4e |
| Default Java | 1.8.0_111 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-9588/yetus/diff-checkstyle-itests_util.txt |
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-9588/yetus/whitespace-eol.txt |
| asflicense | http://104.198.109.242/logs//PreCommit-HIVE-Build-9588/yetus/patch-asflicense-problems.txt |
| modules | C: itests/util U: itests/util |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-9588/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> qtests: QTestUtil refactor/split - QOutProcessor
> ------------------------------------------------
>
> Key: HIVE-18560
> URL: https://issues.apache.org/jira/browse/HIVE-18560
> Project: Hive
> Issue Type: Task
> Components: Tests
> Reporter: Laszlo Bodor
> Assignee: Laszlo Bodor
> Priority: Major
> Attachments: HIVE-18560.01.patch
>
>
> QTestUtil needs some refactoring, as it has become a large, hard-to-maintain, hard-to-test class with a bunch of responsibilities:
> * running qtests
> * parsing/evaluating results
> * masking/processing results
> First, I would extract a processing class from it (e.g. QOutProcessor or something like that), which should be capable of being tested easily, and contains all the logic what's needed to make the final q.out results from the original q.out file.
> This processing class shall remain untouched in case the testing infrastructure (QTestUtil) is replaced or changed in some ways.
--
This message was sent by Atlassian JIRA
(v7.6.3#76005)