You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@nifi.apache.org by "lordgamez (via GitHub)" <gi...@apache.org> on 2023/03/06 08:44:31 UTC
[GitHub] [nifi-minifi-cpp] lordgamez opened a new pull request, #1524: MINIFICPP-2067 Remove OpenSSL system dependency from MQTT
lordgamez opened a new pull request, #1524:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1524
https://issues.apache.org/jira/browse/MINIFICPP-2067
-----------------
Thank you for submitting a contribution to Apache NiFi - MiNiFi C++.
In order to streamline the review of the contribution we ask you
to ensure the following steps have been taken:
### For all changes:
- [ ] Is there a JIRA ticket associated with this PR? Is it referenced
in the commit message?
- [ ] Does your PR title start with MINIFICPP-XXXX where XXXX is the JIRA number you are trying to resolve? Pay particular attention to the hyphen "-" character.
- [ ] Has your PR been rebased against the latest commit within the target branch (typically main)?
- [ ] Is your initial contribution a single, squashed commit?
### For code changes:
- [ ] If adding new dependencies to the code, are these dependencies licensed in a way that is compatible for inclusion under [ASF 2.0](http://www.apache.org/legal/resolved.html#category-a)?
- [ ] If applicable, have you updated the LICENSE file?
- [ ] If applicable, have you updated the NOTICE file?
### For documentation related changes:
- [ ] Have you ensured that format looks appropriate for the output in which it is rendered?
### Note:
Please ensure that once the PR is submitted, you check GitHub Actions CI results for build issues and submit an update to your PR as soon as possible.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm closed pull request #1524: MINIFICPP-2067 Remove OpenSSL system dependency from MQTT
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm closed pull request #1524: MINIFICPP-2067 Remove OpenSSL system dependency from MQTT
URL: https://github.com/apache/nifi-minifi-cpp/pull/1524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1524: MINIFICPP-2067 Remove OpenSSL system dependency from MQTT
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on PR #1524:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1524#issuecomment-1456021294
I've asked @martinzink to have a look at that test. I wouldn't block this PR because of that failure.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] fgerlits commented on a diff in pull request #1524: MINIFICPP-2067 Remove OpenSSL system dependency from MQTT
Posted by "fgerlits (via GitHub)" <gi...@apache.org>.
fgerlits commented on code in PR #1524:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1524#discussion_r1126137730
##########
thirdparty/paho-mqtt/cmake-openssl.patch:
##########
@@ -0,0 +1,26 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 7bfee10..5debc1f 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -23,7 +23,7 @@ MESSAGE(STATUS "CMake version: " ${CMAKE_VERSION})
+ MESSAGE(STATUS "CMake system name: " ${CMAKE_SYSTEM_NAME})
+
+ SET(CMAKE_SCRIPTS "${CMAKE_SOURCE_DIR}/cmake")
+-SET(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules")
++list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules")
+
+ ## build settings
+ file(READ version.major PAHO_VERSION_MAJOR)
+diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
+index 0bc7194..5d35b17 100644
+--- a/src/CMakeLists.txt
++++ b/src/CMakeLists.txt
+@@ -187,7 +187,7 @@ INSTALL(FILES MQTTAsync.h MQTTClient.h MQTTClientPersistence.h MQTTProperties.h
+
+ IF (PAHO_WITH_SSL)
+ SET(OPENSSL_ROOT_DIR "" CACHE PATH "Directory containing OpenSSL libraries and includes")
+- find_package(OpenSSL REQUIRED)
++ # find_package(OpenSSL REQUIRED)
+
+ IF (PAHO_BUILD_SHARED)
+ ## common compilation for libpaho-mqtt3cs and libpaho-mqtt3as
Review Comment:
I don't think this part is needed: with the fixed `CMAKE_MODULE_PATH`, CMake will find our custom `FindOpenSSL.cmake` module. With just the `SET -> list APPEND` change, we have a chance of getting this fix accepted upstream.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on a diff in pull request #1524: MINIFICPP-2067 Remove OpenSSL system dependency from MQTT
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on code in PR #1524:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1524#discussion_r1126157629
##########
thirdparty/paho-mqtt/cmake-openssl.patch:
##########
@@ -0,0 +1,26 @@
+diff --git a/CMakeLists.txt b/CMakeLists.txt
+index 7bfee10..5debc1f 100644
+--- a/CMakeLists.txt
++++ b/CMakeLists.txt
+@@ -23,7 +23,7 @@ MESSAGE(STATUS "CMake version: " ${CMAKE_VERSION})
+ MESSAGE(STATUS "CMake system name: " ${CMAKE_SYSTEM_NAME})
+
+ SET(CMAKE_SCRIPTS "${CMAKE_SOURCE_DIR}/cmake")
+-SET(CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules")
++list(APPEND CMAKE_MODULE_PATH "${CMAKE_SOURCE_DIR}/cmake/modules")
+
+ ## build settings
+ file(READ version.major PAHO_VERSION_MAJOR)
+diff --git a/src/CMakeLists.txt b/src/CMakeLists.txt
+index 0bc7194..5d35b17 100644
+--- a/src/CMakeLists.txt
++++ b/src/CMakeLists.txt
+@@ -187,7 +187,7 @@ INSTALL(FILES MQTTAsync.h MQTTClient.h MQTTClientPersistence.h MQTTProperties.h
+
+ IF (PAHO_WITH_SSL)
+ SET(OPENSSL_ROOT_DIR "" CACHE PATH "Directory containing OpenSSL libraries and includes")
+- find_package(OpenSSL REQUIRED)
++ # find_package(OpenSSL REQUIRED)
+
+ IF (PAHO_BUILD_SHARED)
+ ## common compilation for libpaho-mqtt3cs and libpaho-mqtt3as
Review Comment:
I checked the CMake logs and you are right it finds the right package without it, I removed it in 100d83d9751c09383ad6a46ce3bb87a9a5239e09
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] lordgamez commented on pull request #1524: MINIFICPP-2067 Remove OpenSSL system dependency from MQTT
Posted by "lordgamez (via GitHub)" <gi...@apache.org>.
lordgamez commented on PR #1524:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1524#issuecomment-1456019881
The only failed test is from the `ExpressionLanguageTests` suite from the line:
```
CHECK( LogTestController::getInstance().contains("reverseDnsLookup timed out", 0ms) )
```
It looks to be a flaky test from the Reverse DNS lookup feature.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [nifi-minifi-cpp] szaszm commented on pull request #1524: MINIFICPP-2067 Remove OpenSSL system dependency from MQTT
Posted by "szaszm (via GitHub)" <gi...@apache.org>.
szaszm commented on PR #1524:
URL: https://github.com/apache/nifi-minifi-cpp/pull/1524#issuecomment-1455728251
This fixed the windows cmake error for me. The build didn't finish yet, but it used to fail in the configure step.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@nifi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org