You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@ignite.apache.org by GitBox <gi...@apache.org> on 2019/10/21 09:57:06 UTC

[GitHub] [ignite] alex-plekhanov commented on a change in pull request #6986: IGNITE-12302 Test ZookeeperDiscoveryTopologyChangeAndReconnectTest.testDuplicatedNodeId is broken.

alex-plekhanov commented on a change in pull request #6986: IGNITE-12302 Test ZookeeperDiscoveryTopologyChangeAndReconnectTest.testDuplicatedNodeId is broken.
URL: https://github.com/apache/ignite/pull/6986#discussion_r336929996
 
 

 ##########
 File path: modules/zookeeper/src/test/java/org/apache/ignite/spi/discovery/zk/internal/ZookeeperDiscoveryTopologyChangeAndReconnectTest.java
 ##########
 @@ -562,32 +564,23 @@ public void testForcibleClientFail() throws Exception {
      * @throws Exception If failed.
      */
     @Test
+    @WithSystemProperty(key = IGNITE_SQL_DISABLE_SYSTEM_VIEWS, value = "true")
 
 Review comment:
   `IgniteH2Indexing` connects to H2 instance by URL based on nodeId, so there can be more errors in indexing here in the future even if system views are disabled.
   Perhaps it's better to disable indexing at all for this test (something like `GridQueryProcessor.idxCls = DummyQueryIndexing.class;` before each grid start).

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services