You are viewing a plain text version of this content. The canonical link for it is here.
Posted to derby-dev@db.apache.org by "Kristian Waagan (JIRA)" <ji...@apache.org> on 2008/10/07 17:28:44 UTC
[jira] Resolved: (DERBY-3728) Fix error handling in
PrivilegedFileOpsForTests
[ https://issues.apache.org/jira/browse/DERBY-3728?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Kristian Waagan resolved DERBY-3728.
------------------------------------
Resolution: Fixed
Derby Info: (was: [Patch Available])
Committed 'derby-3728-1a.diff' to trunk with revision 702518.
> Fix error handling in PrivilegedFileOpsForTests
> -----------------------------------------------
>
> Key: DERBY-3728
> URL: https://issues.apache.org/jira/browse/DERBY-3728
> Project: Derby
> Issue Type: Bug
> Components: Test
> Affects Versions: 10.5.0.0
> Reporter: Kristian Waagan
> Assignee: Kristian Waagan
> Priority: Minor
> Fix For: 10.5.0.0
>
> Attachments: derby-3728-1a.diff
>
>
> The exception handling in this utility class is unclear and can in some cases cause ClassCastException to be thrown.
> Note that SecurityException is a runtime exception.
> Potential issues to be fixed:
> 1) Avoid possibility of ClassCastException in 'getFileInputStream'
> 2) Don't include SecurityException in the signature (throws clause)
> 3) Document SecurityException in JavaDoc.
> Points 2 and 3 leads to the option of not catching SecurityException, which allows the code to be written more concisely and we can use PrivilegedAction instead of PrivilegedExceptionAction in some cases.
> There is also a missing character in the class name in the header, and an invalid JavaDoc tag in the class JavaDoc.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.