You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@arrow.apache.org by "ianmcook (via GitHub)" <gi...@apache.org> on 2026/04/07 03:53:24 UTC

[PR] Add option to build posts with dates in the future [arrow-site]

ianmcook opened a new pull request, #774:
URL: https://github.com/apache/arrow-site/pull/774

   (no comment)


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build posts with dates in the future [arrow-site]

Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #774:
URL: https://github.com/apache/arrow-site/pull/774#issuecomment-4196347638

   Preview URL: https://ianmcook.github.io/arrow-site
   
   If the preview URL doesn't work, you may forget to configure your fork repository for preview.
   See https://github.com/apache/arrow-site/blob/main/README.md#forks how to configure.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #774:
URL: https://github.com/apache/arrow-site/pull/774#issuecomment-5842698153

   Completed. I merge this.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou merged PR #774:
URL: https://github.com/apache/arrow-site/pull/774


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook commented on PR #774:
URL: https://github.com/apache/arrow-site/pull/774#issuecomment-4203082583

   Hmm, good question. Someone might have a reason, I suppose, but I can't think of an obvious one.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #774:
URL: https://github.com/apache/arrow-site/pull/774#issuecomment-5849480198

   Thank you @kou an @ianmcook 🙏 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "ianmcook (via GitHub)" <gi...@apache.org>.
ianmcook commented on PR #774:
URL: https://github.com/apache/arrow-site/pull/774#issuecomment-4204012989

   > Let's enable `--future` by default.
   
   Done in a08e969


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on PR #774:
URL: https://github.com/apache/arrow-site/pull/774#issuecomment-5842620471

   I've pushed my suggestion and alamb's suggesion.
   
   I'll merge this once CI is completed.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "kou (via GitHub)" <gi...@apache.org>.
kou commented on code in PR #774:
URL: https://github.com/apache/arrow-site/pull/774#discussion_r3049577947


##########
Rakefile:
##########
@@ -57,5 +58,7 @@ task :generate => webpacked_js do
   command_line << "--config=_config.yml,#{extra_config}" if extra_config
   destination = ENV["JEKYLL_DESTINATION"]
   command_line << "--destination=#{destination}" if destination
+  future = ENV["JEKYLL_FUTURE"]
+  command_line << "--future" if future

Review Comment:
   We can simplify this:
   
   ```suggestion
     command_line << "--future" if ENV["JEKYLL_FUTURE"]
   ```
   
   BTW, do we need this? If we need this, how about enable this only for preview?
   
   ```diff
   diff --git a/.github/workflows/deploy.yml b/.github/workflows/deploy.yml
   index 9b963f13831..86236479f95 100644
   --- a/.github/workflows/deploy.yml
   +++ b/.github/workflows/deploy.yml
   @@ -64,6 +64,9 @@ jobs:
              export JEKYLL_DESTINATION=../build
              export JEKYLL_ENV=production
              export JEKYLL_EXTRA_CONFIG=_extra_config.yml
   +          if [ "${GITHUB_REPOSITORY}" != "apache/arrow-site" ]; then
   +            export JEKYLL_FUTURE=1
   +          fi
              bundle exec rake generate
          - name: Checkout asf-site
            uses: actions/checkout@v6
   ```



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on PR #774:
URL: https://github.com/apache/arrow-site/pull/774#issuecomment-5832753478

   Shall we merge this?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "lidavidm (via GitHub)" <gi...@apache.org>.
lidavidm commented on code in PR #774:
URL: https://github.com/apache/arrow-site/pull/774#discussion_r3049377449


##########
README.md:
##########


Review Comment:
   This is unnecessary now right?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org

Re: [PR] Add option to build and serve posts with dates in the future [arrow-site]

Posted by "alamb (via GitHub)" <gi...@apache.org>.
alamb commented on code in PR #774:
URL: https://github.com/apache/arrow-site/pull/774#discussion_r3704326465


##########
README.md:
##########
@@ -63,6 +63,12 @@ site locally:
 bundle exec rake
 ```
 
+To include posts with future dates:

Review Comment:
   are we changing to always allow future dates? If so we can probably remove this part too



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@arrow.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org