You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hive.apache.org by "Hive QA (Jira)" <ji...@apache.org> on 2019/11/06 13:34:00 UTC
[jira] [Commented] (HIVE-22405) Add ColumnVector support for
ProlepticCalendar
[ https://issues.apache.org/jira/browse/HIVE-22405?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16968367#comment-16968367 ]
Hive QA commented on HIVE-22405:
--------------------------------
| (x) *{color:red}-1 overall{color}* |
\\
\\
|| Vote || Subsystem || Runtime || Comment ||
|| || || || {color:brown} Prechecks {color} ||
| {color:green}+1{color} | {color:green} @author {color} | {color:green} 0m 0s{color} | {color:green} The patch does not contain any @author tags. {color} |
|| || || || {color:brown} master Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 2m 2s{color} | {color:blue} Maven dependency ordering for branch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 7m 57s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 24s{color} | {color:green} master passed {color} |
| {color:green}+1{color} | {color:green} checkstyle {color} | {color:green} 0m 58s{color} | {color:green} master passed {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 0m 24s{color} | {color:blue} storage-api in master has 48 extant Findbugs warnings. {color} |
| {color:blue}0{color} | {color:blue} findbugs {color} | {color:blue} 4m 14s{color} | {color:blue} ql in master has 1550 extant Findbugs warnings. {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 16s{color} | {color:green} master passed {color} |
|| || || || {color:brown} Patch Compile Tests {color} ||
| {color:blue}0{color} | {color:blue} mvndep {color} | {color:blue} 0m 28s{color} | {color:blue} Maven dependency ordering for patch {color} |
| {color:green}+1{color} | {color:green} mvninstall {color} | {color:green} 1m 43s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} compile {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} |
| {color:green}+1{color} | {color:green} javac {color} | {color:green} 1m 19s{color} | {color:green} the patch passed {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 12s{color} | {color:red} storage-api: The patch generated 4 new + 12 unchanged - 6 fixed = 16 total (was 18) {color} |
| {color:red}-1{color} | {color:red} checkstyle {color} | {color:red} 0m 43s{color} | {color:red} ql: The patch generated 2 new + 379 unchanged - 1 fixed = 381 total (was 380) {color} |
| {color:red}-1{color} | {color:red} whitespace {color} | {color:red} 0m 0s{color} | {color:red} The patch has 2 line(s) that end in whitespace. Use git apply --whitespace=fix <<patch_file>>. Refer https://git-scm.com/docs/git-apply {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 0m 31s{color} | {color:red} storage-api generated 8 new + 48 unchanged - 0 fixed = 56 total (was 48) {color} |
| {color:red}-1{color} | {color:red} findbugs {color} | {color:red} 4m 22s{color} | {color:red} ql generated 2 new + 1548 unchanged - 2 fixed = 1550 total (was 1550) {color} |
| {color:green}+1{color} | {color:green} javadoc {color} | {color:green} 1m 13s{color} | {color:green} the patch passed {color} |
|| || || || {color:brown} Other Tests {color} ||
| {color:green}+1{color} | {color:green} asflicense {color} | {color:green} 0m 14s{color} | {color:green} The patch does not generate ASF License warnings. {color} |
| {color:black}{color} | {color:black} {color} | {color:black} 29m 51s{color} | {color:black} {color} |
\\
\\
|| Reason || Tests ||
| FindBugs | module:storage-api |
| | Call to method of static java.text.DateFormat in org.apache.hadoop.hive.ql.exec.vector.DateColumnVector.updateDataAccordingProlepticSetting() At DateColumnVector.java:java.text.DateFormat in org.apache.hadoop.hive.ql.exec.vector.DateColumnVector.updateDataAccordingProlepticSetting() At DateColumnVector.java:[line 72] |
| | Call to method of static java.text.DateFormat in org.apache.hadoop.hive.ql.exec.vector.DateColumnVector.updateDataAccordingProlepticSetting() At DateColumnVector.java:java.text.DateFormat in org.apache.hadoop.hive.ql.exec.vector.DateColumnVector.updateDataAccordingProlepticSetting() At DateColumnVector.java:[line 71] |
| | org.apache.hadoop.hive.ql.exec.vector.DateColumnVector.GREGORIAN_CALENDAR is static field of type java.util.Calendar, which isn't thread safe In DateColumnVector.java:type java.util.Calendar, which isn't thread safe In DateColumnVector.java |
| | org.apache.hadoop.hive.ql.exec.vector.DateColumnVector.PROLEPTIC_GREGORIAN_CALENDAR is static field of type java.util.Calendar, which isn't thread safe In DateColumnVector.java:type java.util.Calendar, which isn't thread safe In DateColumnVector.java |
| | Call to method of static java.text.DateFormat in org.apache.hadoop.hive.ql.exec.vector.TimestampColumnVector.updateDataAccordingProlepticSetting() At TimestampColumnVector.java:java.text.DateFormat in org.apache.hadoop.hive.ql.exec.vector.TimestampColumnVector.updateDataAccordingProlepticSetting() At TimestampColumnVector.java:[line 594] |
| | Call to method of static java.text.DateFormat in org.apache.hadoop.hive.ql.exec.vector.TimestampColumnVector.updateDataAccordingProlepticSetting() At TimestampColumnVector.java:java.text.DateFormat in org.apache.hadoop.hive.ql.exec.vector.TimestampColumnVector.updateDataAccordingProlepticSetting() At TimestampColumnVector.java:[line 593] |
| | org.apache.hadoop.hive.ql.exec.vector.TimestampColumnVector.GREGORIAN_CALENDAR_UTC is static field of type java.util.Calendar, which isn't thread safe In TimestampColumnVector.java:type java.util.Calendar, which isn't thread safe In TimestampColumnVector.java |
| | org.apache.hadoop.hive.ql.exec.vector.TimestampColumnVector.PROLEPTIC_GREGORIAN_CALENDAR_UTC is static field of type java.util.Calendar, which isn't thread safe In TimestampColumnVector.java:type java.util.Calendar, which isn't thread safe In TimestampColumnVector.java |
| FindBugs | module:ql |
| | Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateDiffColCol.copySelected(BytesColumnVector, boolean, int[], int, DateColumnVector):in org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateDiffColCol.copySelected(BytesColumnVector, boolean, int[], int, DateColumnVector): new String(byte[], int, int) At VectorUDFDateDiffColCol.java:[line 217] |
| | Found reliance on default encoding in org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateDiffColCol.setDays(BytesColumnVector, DateColumnVector, int):in org.apache.hadoop.hive.ql.exec.vector.expressions.VectorUDFDateDiffColCol.setDays(BytesColumnVector, DateColumnVector, int): new String(byte[], int, int) At VectorUDFDateDiffColCol.java:[line 296] |
\\
\\
|| Subsystem || Report/Notes ||
| Optional Tests | asflicense javac javadoc findbugs checkstyle compile |
| uname | Linux hiveptest-server-upstream 3.16.0-4-amd64 #1 SMP Debian 3.16.43-2+deb8u5 (2017-09-19) x86_64 GNU/Linux |
| Build tool | maven |
| Personality | /data/hiveptest/working/yetus_PreCommit-HIVE-Build-19313/dev-support/hive-personality.sh |
| git revision | master / d0bd071 |
| Default Java | 1.8.0_111 |
| findbugs | v3.0.1 |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-19313/yetus/diff-checkstyle-storage-api.txt |
| checkstyle | http://104.198.109.242/logs//PreCommit-HIVE-Build-19313/yetus/diff-checkstyle-ql.txt |
| whitespace | http://104.198.109.242/logs//PreCommit-HIVE-Build-19313/yetus/whitespace-eol.txt |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-19313/yetus/new-findbugs-storage-api.html |
| findbugs | http://104.198.109.242/logs//PreCommit-HIVE-Build-19313/yetus/new-findbugs-ql.html |
| modules | C: storage-api ql U: . |
| Console output | http://104.198.109.242/logs//PreCommit-HIVE-Build-19313/yetus.txt |
| Powered by | Apache Yetus http://yetus.apache.org |
This message was automatically generated.
> Add ColumnVector support for ProlepticCalendar
> ----------------------------------------------
>
> Key: HIVE-22405
> URL: https://issues.apache.org/jira/browse/HIVE-22405
> Project: Hive
> Issue Type: Bug
> Reporter: Owen O'Malley
> Assignee: László Bodor
> Priority: Major
> Attachments: HIVE-22405.01.patch
>
>
> Hive recently moved its processing to the proleptic calendar, which has created some issues for users who have dates before 1580 AD.
> I'd propose extending the column vectors for times & dates to encode which calendar they are using.
> * create DateColumnVector that extends LongColumnVector
> * add a method to change calendars to both DateColumnVector and TimestampColumnVector.
> {code}
> /**
> * Change the calendar to or from proleptic. If the new and old values of the flag are the
> * same, nothing is done.
> * useProleptic - set the flag for the proleptic calendar
> * updateData - change the data to match the new value of the flag.
> */
> void changeCalendar(useProleptic: boolean, updateData: boolean);
> /**
> * Detect whether this data is using the proleptic calendar.
> */
> boolean usingProlepticCalendar();
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)