You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@apisix.apache.org by GitBox <gi...@apache.org> on 2021/07/04 05:52:38 UTC
[GitHub] [apisix-docker] iamayushdas opened a new pull request #194: docs: removed `$` from code snippets
iamayushdas opened a new pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194
removed `$` from code snippets so that while copying from copy button on copy buttons doesn't copy trailing dollars
@spacewander @Yiyiyimu
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] commented on pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#issuecomment-967977209
This pull request has been marked as stale due to 60 days of inactivity. It will be closed in 4 weeks if no further activity occurs. If you think that's incorrect or this pull request should instead be reviewed, please simply write any comment. Even if closed, you can still revive the PR at any time ordiscuss it on the dev@apisix.apache.org list. Thank you for your contributions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] closed pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#issuecomment-873616632
Hi @iamayushdas could you also fix the ones in README
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] commented on pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#issuecomment-991583351
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] leslie-tsang commented on pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
leslie-tsang commented on pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#issuecomment-918853086
Any update for this PR? @iamayushdas
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] iamayushdas commented on pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#issuecomment-873616736
Sure
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] closed pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
github-actions[bot] closed pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] iamayushdas commented on a change in pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on a change in pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#discussion_r677964031
##########
File path: README.md
##########
@@ -11,36 +11,37 @@
# Assign Apache release version number to variable `APISIX_VERSION`, for example: 2.6. The latest version can be find at `https://github.com/apache/apisix/releases`
export APISIX_VERSION=2.6
+
# alpine
-$ make build-on-alpine
+make build-on-alpine
Review comment:
Yes i have
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#discussion_r671906753
##########
File path: README.md
##########
@@ -11,36 +11,37 @@
# Assign Apache release version number to variable `APISIX_VERSION`, for example: 2.6. The latest version can be find at `https://github.com/apache/apisix/releases`
export APISIX_VERSION=2.6
+
# alpine
-$ make build-on-alpine
+make build-on-alpine
Review comment:
I believe we should separate command for alpine and centos into to code block, since people won't use them at the same time
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] Yiyiyimu commented on a change in pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
Yiyiyimu commented on a change in pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#discussion_r677951343
##########
File path: README.md
##########
@@ -11,36 +11,37 @@
# Assign Apache release version number to variable `APISIX_VERSION`, for example: 2.6. The latest version can be find at `https://github.com/apache/apisix/releases`
export APISIX_VERSION=2.6
+
# alpine
-$ make build-on-alpine
+make build-on-alpine
Review comment:
cc @iamayushdas do you have time working on this
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] iamayushdas commented on pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
iamayushdas commented on pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#issuecomment-879515798
cc @Yiyiyimu done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [apisix-docker] github-actions[bot] commented on pull request #194: docs: removed `$` from code snippets
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on pull request #194:
URL: https://github.com/apache/apisix-docker/pull/194#issuecomment-991583351
This pull request/issue has been closed due to lack of activity. If you think that is incorrect, or the pull request requires review, you can revive the PR at any time.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@apisix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org