You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by "fangchenli (via GitHub)" <gi...@apache.org> on 2026/07/17 21:48:22 UTC
[PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
fangchenli opened a new pull request, #57343:
URL: https://github.com/apache/spark/pull/57343
<!--
Thanks for sending a pull request! Here are some tips for you:
1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
4. Be sure to keep the PR description updated to reflect all changes.
5. Please write your PR title to summarize what this PR proposes.
6. If possible, provide a concise example to reproduce the issue for a faster review.
7. If you want to add a new configuration, please read the guideline first for naming configurations in
'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
8. If you want to add or modify an error type or message, please read the guideline first in
'common/utils/src/main/resources/error/README.md'.
-->
### What changes were proposed in this pull request?
<!--
Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue.
If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
2. If you fix some SQL features, you can provide some references of other DBMSes.
3. If there is design documentation, please add the link.
4. If there is a discussion in the mailing list, please add the link.
-->
Adds a Scala 3 build target alongside 2.13: a scala-3 Maven profile (Scala 3.3.8) and a reversible dev/change-scala-version.sh (2.13 <-> 3). Coordinates with no Scala 3 build are pinned to their own property (chill as chill_2.13, mvn-scalafmt), and genjavadoc is disabled under Scala 3. It is not expected to compile the whole reactor yet; it is the target modules get ported against.
### Why are the changes needed?
<!--
Please clarify why the changes are needed. For instance,
1. If you propose a new API, clarify the use case for a new API.
2. If you fix a bug, you can clarify why it is a bug.
-->
There is currently no way to build the project against Scala 3, since the cross-version tooling only targets 2.13. A Scala 3 build target is a prerequisite for porting modules and measuring progress one at a time, the same way the Scala-2.13 profile (SPARK-29296) was added well before 2.13 was actually built.
### Does this PR introduce _any_ user-facing change?
<!--
Note that it means *any* user-facing change including all aspects such as new features, bug fixes, or other behavior changes. Documentation-only updates are not considered user-facing changes.
If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
If no, write 'No'.
-->
No.
### How was this patch tested?
<!--
If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
If tests were not added, please describe why they were not added and/or why it was difficult to add.
If benchmark tests were added, please run the benchmarks in GitHub Actions for the consistent environment, and the instructions could accord to: https://spark.apache.org/developer-tools.html#github-workflow-benchmarks.
-->
Manually tested.
### Was this patch authored or co-authored using generative AI tooling?
<!--
If generative AI tooling has been used in the process of authoring this patch, please include the
phrase: 'Generated-by: ' followed by the name of the tool and its version.
If no, write 'No'.
Please refer to the [ASF Generative Tooling Guidance](https://www.apache.org/legal/generative-tooling.html) for details.
-->
Generated-by: Claude Code (Opus 4.8)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "LuciferYang (via GitHub)" <gi...@apache.org>.
LuciferYang commented on PR #57343:
URL: https://github.com/apache/spark/pull/57343#issuecomment-5384231358
@fangchenli If you are genuinely motivated to push this forward, please provide the SPIP document and initiate a discussion on the dev mailing list. Proceed with code changes only after a consensus has been reached.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #57343:
URL: https://github.com/apache/spark/pull/57343#discussion_r3635941128
##########
common/utils/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala:
##########
@@ -155,7 +155,7 @@ private[spark] class TypedConfigBuilder[T](
import ConfigHelpers._
def this(parent: ConfigBuilder, converter: String => T) = {
- this(parent, converter, { v: T => v.toString })
+ this(parent, converter, { (v: T) => v.toString })
Review Comment:
Ditto. Is this a source-code-level breaking change of Scala 3?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "fangchenli (via GitHub)" <gi...@apache.org>.
fangchenli commented on code in PR #57343:
URL: https://github.com/apache/spark/pull/57343#discussion_r3635984533
##########
common/utils/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala:
##########
@@ -56,7 +56,7 @@ private object ConfigHelpers {
def toEnum[E <: Enum[E]](s: String, enumClass: Class[E], key: String): E = {
enumClass.getEnumConstants.find(_.name().equalsIgnoreCase(s.trim)) match {
- case Some(enum) => enum
+ case Some(e) => e
Review Comment:
`enum` is a keyword in Scala 3.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "fangchenli (via GitHub)" <gi...@apache.org>.
fangchenli commented on code in PR #57343:
URL: https://github.com/apache/spark/pull/57343#discussion_r3636079057
##########
common/utils/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala:
##########
@@ -155,7 +155,7 @@ private[spark] class TypedConfigBuilder[T](
import ConfigHelpers._
def this(parent: ConfigBuilder, converter: String => T) = {
- this(parent, converter, { v: T => v.toString })
+ this(parent, converter, { (v: T) => v.toString })
Review Comment:
The old syntax is no longer valid in Scala 3.
Those two code changes are slightly out of scope for this PR. But without them, only a few Scala files can be compiled. Happy to split them into a separate PR if you prefer this PR to stay free of source changes.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "fangchenli (via GitHub)" <gi...@apache.org>.
fangchenli commented on PR #57343:
URL: https://github.com/apache/spark/pull/57343#issuecomment-5429868459
> Thank you @dongjoon-hyun and @LuciferYang for chiming in on this!
>
> Sorry @fangchenli I didn't scope this properly in the beginning, perhaps we should close this PR Still it seems like there is a path forward for a holistic approach in case that you are still interested
I'll start a SPIP for this. In the meantime, I'll keep this PR open and updated. If we decide to do this differently later, we can still use it as a reference.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #57343:
URL: https://github.com/apache/spark/pull/57343#discussion_r3635939872
##########
common/utils/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala:
##########
@@ -56,7 +56,7 @@ private object ConfigHelpers {
def toEnum[E <: Enum[E]](s: String, enumClass: Class[E], key: String): E = {
enumClass.getEnumConstants.find(_.name().equalsIgnoreCase(s.trim)) match {
- case Some(enum) => enum
+ case Some(e) => e
Review Comment:
Why do we change like this, @fangchenli ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "dongjoon-hyun (via GitHub)" <gi...@apache.org>.
dongjoon-hyun commented on code in PR #57343:
URL: https://github.com/apache/spark/pull/57343#discussion_r3636581023
##########
common/utils/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala:
##########
@@ -155,7 +155,7 @@ private[spark] class TypedConfigBuilder[T](
import ConfigHelpers._
def this(parent: ConfigBuilder, converter: String => T) = {
- this(parent, converter, { v: T => v.toString })
+ this(parent, converter, { (v: T) => v.toString })
Review Comment:
IIRC, there exists some PRs (before this PR) for this kind of breaking Scala 3 language change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57343:
URL: https://github.com/apache/spark/pull/57343#issuecomment-5048040131
cc @LuciferYang @dongjoon-hyun
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "uros-b (via GitHub)" <gi...@apache.org>.
uros-b commented on PR #57343:
URL: https://github.com/apache/spark/pull/57343#issuecomment-5410249466
Thank you @dongjoon-hyun and @LuciferYang for chiming in on this!
Sorry @fangchenli I didn't scope this properly in the beginning, perhaps we should close this PR
Still it seems like there is a path forward for a holistic approach in case that you are still interested
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org
Re: [PR] [SPARK-58200][BUILD] Add a scala-3 build profile and make the version switch reversible [spark]
Posted by "fangchenli (via GitHub)" <gi...@apache.org>.
fangchenli commented on code in PR #57343:
URL: https://github.com/apache/spark/pull/57343#discussion_r3639667382
##########
common/utils/src/main/scala/org/apache/spark/internal/config/ConfigBuilder.scala:
##########
@@ -155,7 +155,7 @@ private[spark] class TypedConfigBuilder[T](
import ConfigHelpers._
def this(parent: ConfigBuilder, converter: String => T) = {
- this(parent, converter, { v: T => v.toString })
+ this(parent, converter, { (v: T) => v.toString })
Review Comment:
A few of those were done during the 2.12-2.13 transition. And I added links to those in the Scala 3 tracker. And https://github.com/apache/spark/pull/50474 was an early attempt to fix all of them in one go, but it never land.
https://github.com/apache/spark/pull/43472
https://github.com/apache/spark/pull/43487
https://github.com/apache/spark/pull/32710
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org