[GitHub] [superset] ktmud commented on a change in pull request #12668: feat: periodically github release

[GitBox <gi...@apache.org>]

ktmud commented on a change in pull request #12668:
URL: https://github.com/apache/superset/pull/12668#discussion_r562404098



##########
File path: .github/workflows/scheduled_release.yml
##########
@@ -0,0 +1,34 @@
+on:
+
+  schedule:
+    - cron: '0 0 * * 2'  # https://crontab.guru/#0_0_*_*_2
+
+name: Create Release
+
+jobs:
+  build:
+    name: Create Release
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Get current date
+        id: date
+        run: echo "name=$(date +'%Y-%m-%d')" >> $GITHUB_ENV

Review comment:
       You can also use this officially supported magic echo to set step outputs: https://docs.github.com/en/actions/reference/workflow-commands-for-github-actions#setting-an-output-parameter

##########
File path: .github/workflows/scheduled_release.yml
##########
@@ -0,0 +1,34 @@
+on:
+
+  schedule:
+    - cron: '0 0 * * 2'  # https://crontab.guru/#0_0_*_*_2
+
+name: Create Release
+
+jobs:
+  build:
+    name: Create Release
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout code
+        uses: actions/checkout@v2
+      - name: Get current date
+        id: date
+        run: echo "name=$(date +'%Y-%m-%d')" >> $GITHUB_ENV
+      - name: Test with environment variables
+        run: echo $TAG_NAME - $RELEASE_NAME
+        env:
+          TAG_NAME: weekly-tag-${{ steps.date.outputs.date }}
+          RELEASE_NAME: weekly-release-${{ steps.date.outputs.date }}

Review comment:
       Can we maybe prefix the weekly/nightly builds with current version number as well? So instead of `weekly-release-2021-01-20`, we have `weekly-release-1.0.0-20210120`. Or better yet, `superset-1.0.0-20210120`.

##########
File path: .github/workflows/scheduled_release.yml
##########
@@ -0,0 +1,34 @@
+on:
+
+  schedule:
+    - cron: '0 0 * * 2'  # https://crontab.guru/#0_0_*_*_2

Review comment:
       Maybe use more human-friendly comments?
   
   ```
   Midnight on every Tuesday
   ```
   




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org