You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@qpid.apache.org by ro...@apache.org on 2010/09/28 00:56:21 UTC
svn commit: r1001951 - in /qpid/trunk: ./ qpid/java/ qpid/java/lib/findbugs/

Author: robbie
Date: Mon Sep 27 22:56:20 2010
New Revision: 1001951

URL: http://svn.apache.org/viewvc?rev=1001951&view=rev
Log:
QPID-2857: Remove the FindBugs binarys from the repository and add instructions on how to download and use it.

This is necessary because whilst its deps are fine, FindBugs itself is LGPL licenced. It also doesnt hurt to remove 15MB of optional binaries from the release.

Added:
    qpid/trunk/qpid/java/lib/findbugs/README.txt
Removed:
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-ASM.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-AppleJavaExtensions.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-bcel.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-commons-lang.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-docbook.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-dom4j.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-findbugs.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-jFormatString.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-jaxen.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-jcip.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-jdepend.txt
    qpid/trunk/qpid/java/lib/findbugs/LICENSE-jsr305.txt
    qpid/trunk/qpid/java/lib/findbugs/annotations.jar
    qpid/trunk/qpid/java/lib/findbugs/ant.jar
    qpid/trunk/qpid/java/lib/findbugs/asm-3.1.jar
    qpid/trunk/qpid/java/lib/findbugs/asm-analysis-3.1.jar
    qpid/trunk/qpid/java/lib/findbugs/asm-commons-3.1.jar
    qpid/trunk/qpid/java/lib/findbugs/asm-tree-3.1.jar
    qpid/trunk/qpid/java/lib/findbugs/asm-util-3.1.jar
    qpid/trunk/qpid/java/lib/findbugs/asm-xml-3.1.jar
    qpid/trunk/qpid/java/lib/findbugs/bcel.jar
    qpid/trunk/qpid/java/lib/findbugs/buggy.icns
    qpid/trunk/qpid/java/lib/findbugs/commons-lang-2.4.jar
    qpid/trunk/qpid/java/lib/findbugs/dom4j-1.6.1.jar
    qpid/trunk/qpid/java/lib/findbugs/findbugs-ant.jar
    qpid/trunk/qpid/java/lib/findbugs/findbugs.jar
    qpid/trunk/qpid/java/lib/findbugs/jFormatString.jar
    qpid/trunk/qpid/java/lib/findbugs/jaxen-1.1.1.jar
    qpid/trunk/qpid/java/lib/findbugs/jdepend-2.9.jar
    qpid/trunk/qpid/java/lib/findbugs/jsr305.jar
Modified:
    qpid/trunk/.gitignore
    qpid/trunk/qpid/java/build.xml
    qpid/trunk/qpid/java/common.xml

Modified: qpid/trunk/.gitignore
URL: http://svn.apache.org/viewvc/qpid/trunk/.gitignore?rev=1001951&r1=1001950&r2=1001951&view=diff
==============================================================================
--- qpid/trunk/.gitignore (original)
+++ qpid/trunk/.gitignore Mon Sep 27 22:56:20 2010
@@ -35,7 +35,8 @@ release
 .settings
 generated/
 target
-qpid/java/lib/cobertura/
+qpid/java/lib/cobertura
+qpid/java/lib/findbugs
 # Intellij Project files
 *.iml
 *.ipr

Modified: qpid/trunk/qpid/java/build.xml
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/build.xml?rev=1001951&r1=1001950&r2=1001951&view=diff
==============================================================================
--- qpid/trunk/qpid/java/build.xml (original)
+++ qpid/trunk/qpid/java/build.xml Mon Sep 27 22:56:20 2010
@@ -250,7 +250,7 @@
     </jython>
   </target>
 
-  <target name="findbugs" depends="build">
+  <target name="findbugs" depends="findbugs-init,build">
 
     <mkdir dir="${build.findbugs}"/>
 

Modified: qpid/trunk/qpid/java/common.xml
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/common.xml?rev=1001951&r1=1001950&r2=1001951&view=diff
==============================================================================
--- qpid/trunk/qpid/java/common.xml (original)
+++ qpid/trunk/qpid/java/common.xml Mon Sep 27 22:56:20 2010
@@ -180,7 +180,12 @@
     <taskdef classpathref="cobertura.classpath" resource="tasks.properties" />
   </target>
 
-  <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask" classpath="${findbugs.dir}/findbugs-ant.jar"/>
+  <target name="findbugs-init">
+    <available file="${findbugs.dir}/findbugs-ant.jar" property="findbugs-ant.jar.present"/>
+    <fail unless="findbugs-ant.jar.present" message="Please follow the instructions at ${findbugs.dir}/README.txt to configure FindBugs"/>
+
+    <taskdef name="findbugs" classname="edu.umd.cs.findbugs.anttask.FindBugsTask" classpath="${findbugs.dir}/findbugs-ant.jar"/>
+  </target>
 
   <target name="help" description="display detailed build documentation">
     <echo>

Added: qpid/trunk/qpid/java/lib/findbugs/README.txt
URL: http://svn.apache.org/viewvc/qpid/trunk/qpid/java/lib/findbugs/README.txt?rev=1001951&view=auto
==============================================================================
--- qpid/trunk/qpid/java/lib/findbugs/README.txt (added)
+++ qpid/trunk/qpid/java/lib/findbugs/README.txt Mon Sep 27 22:56:20 2010
@@ -0,0 +1,30 @@
+Download the FindBugs archive from the following location:
+http://findbugs.sourceforge.net/downloads.html
+
+Unpack the contents of the 'findbugs-<version>/lib' folder within the archive
+to the 'qpid/java/lib/findbugs' (i.e. this) directory. This should leave you
+with contents of 'qpid/java/lib/findbugs' similar to:
+
+annotations.jar
+ant.jar
+asm-3.1.jar
+asm-analysis-3.1.jar
+asm-commons-3.1.jar
+asm-tree-3.1.jar
+asm-util-3.1.jar
+asm-xml-3.1.jar
+bcel.jar
+buggy.icns
+commons-lang-2.4.jar
+dom4j-1.6.1.jar
+findbugs-ant.jar
+findbugs.jar
+jFormatString.jar
+jaxen-1.1.1.jar
+jdepend-2.9.jar
+jsr305.jar
+mysql-connector-java-5.1.7-bin.jar
+
+
+Now simply run "ant findbugs" in qpid/java to generate the report.
+



---------------------------------------------------------------------
Apache Qpid - AMQP Messaging Implementation
Project:      http://qpid.apache.org
Use/Interact: mailto:commits-subscribe@qpid.apache.org