You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Hadoop QA (JIRA)" <ji...@apache.org> on 2014/02/07 03:08:19 UTC
[jira] [Commented] (ZOOKEEPER-1877) Malformed ACL Id can crash
server with skipACL=yes
[ https://issues.apache.org/jira/browse/ZOOKEEPER-1877?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13894107#comment-13894107 ]
Hadoop QA commented on ZOOKEEPER-1877:
--------------------------------------
+1 overall. Here are the results of testing the latest attachment
http://issues.apache.org/jira/secure/attachment/12627526/ZOOKEEPER-1877.patch
against trunk revision 1561672.
+1 @author. The patch does not contain any @author tags.
+1 tests included. The patch appears to include 5 new or modified tests.
+1 javadoc. The javadoc tool did not generate any warning messages.
+1 javac. The applied patch does not increase the total number of javac compiler warnings.
+1 findbugs. The patch does not introduce any new Findbugs (version 1.3.9) warnings.
+1 release audit. The applied patch does not increase the total number of release audit warnings.
+1 core tests. The patch passed core unit tests.
+1 contrib tests. The patch passed contrib unit tests.
Test results: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1920//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1920//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-ZOOKEEPER-Build/1920//console
This message is automatically generated.
> Malformed ACL Id can crash server with skipACL=yes
> --------------------------------------------------
>
> Key: ZOOKEEPER-1877
> URL: https://issues.apache.org/jira/browse/ZOOKEEPER-1877
> Project: ZooKeeper
> Issue Type: Bug
> Components: server
> Affects Versions: 3.5.0
> Reporter: Chris Chen
> Attachments: ZOOKEEPER-1877.patch
>
>
> Because of the way fixupACL is written in PrepRequestProcessor, a request that feeds in an ACL with null members in the Id will cause a server with skipACL=yes to crash.
> A patch will be provided that re-introduces checks for well-formed ACLs even if skipACL is enabled.
--
This message was sent by Atlassian JIRA
(v6.1.5#6160)