You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2020/10/15 13:39:54 UTC

[GitHub] [spark] MaxGekk opened a new pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

MaxGekk opened a new pull request #30056:
URL: https://github.com/apache/spark/pull/30056


   <!--
   Thanks for sending a pull request!  Here are some tips for you:
     1. If this is your first time, please read our contributor guidelines: https://spark.apache.org/contributing.html
     2. Ensure you have added or run the appropriate tests for your PR: https://spark.apache.org/developer-tools.html
     3. If the PR is unfinished, add '[WIP]' in your PR title, e.g., '[WIP][SPARK-XXXX] Your PR title ...'.
     4. Be sure to keep the PR description updated to reflect all changes.
     5. Please write your PR title to summarize what this PR proposes.
     6. If possible, provide a concise example to reproduce the issue for a faster review.
     7. If you want to add a new configuration, please read the guideline first for naming configurations in
        'core/src/main/scala/org/apache/spark/internal/config/ConfigEntry.scala'.
   -->
   
   ### What changes were proposed in this pull request?
   <!--
   Please clarify what changes you are proposing. The purpose of this section is to outline the changes and how this PR fixes the issue. 
   If possible, please consider writing useful notes for better and faster reviews in your PR. See the examples below.
     1. If you refactor some codes with changing classes, showing the class hierarchy will help reviewers.
     2. If you fix some SQL features, you can provide some references of other DBMSes.
     3. If there is design documentation, please add the link.
     4. If there is a discussion in the mailing list, please add the link.
   -->
   
   
   ### Why are the changes needed?
   <!--
   Please clarify why the changes are needed. For instance,
     1. If you propose a new API, clarify the use case for a new API.
     2. If you fix a bug, you can clarify why it is a bug.
   -->
   
   
   ### Does this PR introduce _any_ user-facing change?
   <!--
   Note that it means *any* user-facing change including all aspects such as the documentation fix.
   If yes, please clarify the previous behavior and the change this PR proposes - provide the console output, description and/or an example to show the behavior difference if possible.
   If possible, please also clarify if this is a user-facing change compared to the released Spark versions or within the unreleased branches such as master.
   If no, write 'No'.
   -->
   
   
   ### How was this patch tested?
   <!--
   If tests were added, say they were added here. Please make sure to add some test cases that check the changes thoroughly including negative and positive cases if possible.
   If it was tested in a way different from regular unit tests, please clarify how you tested step by step, ideally copy and paste-able, so that other reviewers can test and check, and descendants can verify in the future.
   If tests were not added, please describe why they were not added and/or why it was difficult to add.
   -->
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711162525


   **[Test build #129956 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129956/testReport)** for PR 30056 at commit [`fab3a86`](https://github.com/apache/spark/commit/fab3a8690413f4bc13d2f61a28eb769faff76cef).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711045327


   **[Test build #129947 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129947/testReport)** for PR 30056 at commit [`1cc8c3e`](https://github.com/apache/spark/commit/1cc8c3e619021b8065891c91ca8a84ff76b04809).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710337186






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-712610574


   @cloud-fan can you take a look too just for doubly sure?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709509354






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710226062


   **[Test build #129904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129904/testReport)** for PR 30056 at commit [`76330e2`](https://github.com/apache/spark/commit/76330e2a2b27749f652053e793167814ba0eb6e4).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711138314






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711036289


   **[Test build #129945 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129945/testReport)** for PR 30056 at commit [`ab3fc54`](https://github.com/apache/spark/commit/ab3fc5465793b1cf39fd17b1f42734bea7b3147e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710346237






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709471787


   **[Test build #129848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129848/testReport)** for PR 30056 at commit [`4f62e27`](https://github.com/apache/spark/commit/4f62e271f91318607baec264ac53560da502763a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709586100






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710988516






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711057786


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34554/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711131682


   **[Test build #129956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129956/testReport)** for PR 30056 at commit [`fab3a86`](https://github.com/apache/spark/commit/fab3a8690413f4bc13d2f61a28eb769faff76cef).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709443629


   **[Test build #129839 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129839/testReport)** for PR 30056 at commit [`8a16ca1`](https://github.com/apache/spark/commit/8a16ca1d2c441b479726c93e0f84b5acf8f6c66e).
    * This patch **fails Spark unit tests**.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709606023


   **[Test build #129848 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129848/testReport)** for PR 30056 at commit [`4f62e27`](https://github.com/apache/spark/commit/4f62e271f91318607baec264ac53560da502763a).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711051335


   **[Test build #129949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129949/testReport)** for PR 30056 at commit [`55fe5cc`](https://github.com/apache/spark/commit/55fe5ccef1f5858b97fc13b7ef8bad14df68e31e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709444248






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711131682


   **[Test build #129956 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129956/testReport)** for PR 30056 at commit [`fab3a86`](https://github.com/apache/spark/commit/fab3a8690413f4bc13d2f61a28eb769faff76cef).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709368827


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34444/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710337119


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34510/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710957359


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34552/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711083742






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709444263


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder/129839/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710083115






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709441684


   **[Test build #129845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129845/testReport)** for PR 30056 at commit [`0bd60e4`](https://github.com/apache/spark/commit/0bd60e4e0ce97add19dbf4d792130a7457e43fbe).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710654055






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710904985


   **[Test build #129947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129947/testReport)** for PR 30056 at commit [`1cc8c3e`](https://github.com/apache/spark/commit/1cc8c3e619021b8065891c91ca8a84ff76b04809).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710302163


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34510/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711083742






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710904985


   **[Test build #129947 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129947/testReport)** for PR 30056 at commit [`1cc8c3e`](https://github.com/apache/spark/commit/1cc8c3e619021b8065891c91ca8a84ff76b04809).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709477215


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34451/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710900678


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34550/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709335282


   **[Test build #129839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129839/testReport)** for PR 30056 at commit [`8a16ca1`](https://github.com/apache/spark/commit/8a16ca1d2c441b479726c93e0f84b5acf8f6c66e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710083092


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34502/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711036670






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #30056:
URL: https://github.com/apache/spark/pull/30056#discussion_r507669992



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2640,6 +2640,20 @@ object SQLConf {
       .checkValues(LegacyBehaviorPolicy.values.map(_.toString))
       .createWithDefault(LegacyBehaviorPolicy.EXCEPTION.toString)
 
+  val LEGACY_PARQUET_INT96_REBASE_MODE_IN_WRITE =
+    buildConf("spark.sql.legacy.parquet.int96RebaseModeInWrite")
+      .internal()
+      .doc("When LEGACY, which is the default, Spark will rebase INT96 timestamps from " +
+        "Proleptic Gregorian calendar to the legacy hybrid (Julian + Gregorian) calendar when " +
+        "writing Parquet files. When CORRECTED, Spark will not do rebase and write the timestamps" +
+        " as it is. When EXCEPTION, Spark will fail the writing if it sees ancient timestamps " +
+        "that are ambiguous between the two calendars.")
+      .version("3.1.0")
+      .stringConf
+      .transform(_.toUpperCase(Locale.ROOT))
+      .checkValues(LegacyBehaviorPolicy.values.map(_.toString))
+      .createWithDefault(LegacyBehaviorPolicy.LEGACY.toString)

Review comment:
       I am not sure that we can do that in the minor release 3.1. This can break existing apps. @cloud-fan @HyukjinKwon WDYT?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709444248


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709585018


   **[Test build #129845 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129845/testReport)** for PR 30056 at commit [`0bd60e4`](https://github.com/apache/spark/commit/0bd60e4e0ce97add19dbf4d792130a7457e43fbe).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709380651


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34444/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710346237






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710859720


   **[Test build #129945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129945/testReport)** for PR 30056 at commit [`ab3fc54`](https://github.com/apache/spark/commit/ab3fc5465793b1cf39fd17b1f42734bea7b3147e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709509336


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34454/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709498262


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34454/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709509354






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711045795






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709335282


   **[Test build #129839 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129839/testReport)** for PR 30056 at commit [`8a16ca1`](https://github.com/apache/spark/commit/8a16ca1d2c441b479726c93e0f84b5acf8f6c66e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711060962






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710338753


   **[Test build #129897 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129897/testReport)** for PR 30056 at commit [`fb67c68`](https://github.com/apache/spark/commit/fb67c68f8eb025e76c225c8ac38971cc8c6d3210).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds the following public classes _(experimental)_:
     * `  public static class Bitmaps `
     * `  public static class BitmapArrays `
     * `  class BlockPushErrorHandler implements ErrorHandler `
     * `public class MergedBlockMeta `
     * `public class OneForOneBlockPusher `
     * `public class FinalizeShuffleMerge extends BlockTransferMessage `
     * `public class MergeStatuses extends BlockTransferMessage `
     * `public class PushBlockStream extends BlockTransferMessage `
     * `case class Lag(input: Expression, inputOffset: Expression, default: Expression)`


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710859720


   **[Test build #129945 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129945/testReport)** for PR 30056 at commit [`ab3fc54`](https://github.com/apache/spark/commit/ab3fc5465793b1cf39fd17b1f42734bea7b3147e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711083567


   **[Test build #129949 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129949/testReport)** for PR 30056 at commit [`55fe5cc`](https://github.com/apache/spark/commit/55fe5ccef1f5858b97fc13b7ef8bad14df68e31e).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709441684


   **[Test build #129845 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129845/testReport)** for PR 30056 at commit [`0bd60e4`](https://github.com/apache/spark/commit/0bd60e4e0ce97add19dbf4d792130a7457e43fbe).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] cloud-fan commented on a change in pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
cloud-fan commented on a change in pull request #30056:
URL: https://github.com/apache/spark/pull/30056#discussion_r509371638



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2640,6 +2640,20 @@ object SQLConf {
       .checkValues(LegacyBehaviorPolicy.values.map(_.toString))
       .createWithDefault(LegacyBehaviorPolicy.EXCEPTION.toString)
 
+  val LEGACY_PARQUET_INT96_REBASE_MODE_IN_WRITE =
+    buildConf("spark.sql.legacy.parquet.int96RebaseModeInWrite")
+      .internal()
+      .doc("When LEGACY, which is the default, Spark will rebase INT96 timestamps from " +
+        "Proleptic Gregorian calendar to the legacy hybrid (Julian + Gregorian) calendar when " +
+        "writing Parquet files. When CORRECTED, Spark will not do rebase and write the timestamps" +
+        " as it is. When EXCEPTION, Spark will fail the writing if it sees ancient timestamps " +
+        "that are ambiguous between the two calendars.")
+      .version("3.1.0")
+      .stringConf
+      .transform(_.toUpperCase(Locale.ROOT))
+      .checkValues(LegacyBehaviorPolicy.values.map(_.toString))
+      .createWithDefault(LegacyBehaviorPolicy.LEGACY.toString)

Review comment:
       It's a breaking change, but probably is acceptable as it doesn't lead to silent results changing. We need an item in the migration guide though.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] tomvanbussel commented on a change in pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
tomvanbussel commented on a change in pull request #30056:
URL: https://github.com/apache/spark/pull/30056#discussion_r507639347



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2640,6 +2640,20 @@ object SQLConf {
       .checkValues(LegacyBehaviorPolicy.values.map(_.toString))
       .createWithDefault(LegacyBehaviorPolicy.EXCEPTION.toString)
 
+  val LEGACY_PARQUET_INT96_REBASE_MODE_IN_WRITE =
+    buildConf("spark.sql.legacy.parquet.int96RebaseModeInWrite")
+      .internal()
+      .doc("When LEGACY, which is the default, Spark will rebase INT96 timestamps from " +
+        "Proleptic Gregorian calendar to the legacy hybrid (Julian + Gregorian) calendar when " +
+        "writing Parquet files. When CORRECTED, Spark will not do rebase and write the timestamps" +
+        " as it is. When EXCEPTION, Spark will fail the writing if it sees ancient timestamps " +
+        "that are ambiguous between the two calendars.")
+      .version("3.1.0")
+      .stringConf
+      .transform(_.toUpperCase(Locale.ROOT))
+      .checkValues(LegacyBehaviorPolicy.values.map(_.toString))
+      .createWithDefault(LegacyBehaviorPolicy.LEGACY.toString)

Review comment:
       Could the default be made `LegacyBehaviorPolicy.EXCEPTION` instead? Could also do this in a follow-up PR if this is controversial.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711060951


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34554/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711162799






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710651583


   **[Test build #129904 has finished](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129904/testReport)** for PR 30056 at commit [`76330e2`](https://github.com/apache/spark/commit/76330e2a2b27749f652053e793167814ba0eb6e4).
    * This patch passes all tests.
    * This patch merges cleanly.
    * This patch adds no public classes.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710083115






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710069516


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34502/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709586100






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709380699






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710045243


   **[Test build #129897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129897/testReport)** for PR 30056 at commit [`fb67c68`](https://github.com/apache/spark/commit/fb67c68f8eb025e76c225c8ac38971cc8c6d3210).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710926503






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710045243


   **[Test build #129897 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129897/testReport)** for PR 30056 at commit [`fb67c68`](https://github.com/apache/spark/commit/fb67c68f8eb025e76c225c8ac38971cc8c6d3210).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710926444


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34550/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711136098


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34562/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711060966


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34554/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710988516


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711138308


   Kubernetes integration test status success
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34562/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711162799






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709606858






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711051335


   **[Test build #129949 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129949/testReport)** for PR 30056 at commit [`55fe5cc`](https://github.com/apache/spark/commit/55fe5ccef1f5858b97fc13b7ef8bad14df68e31e).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon closed pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
HyukjinKwon closed pull request #30056:
URL: https://github.com/apache/spark/pull/30056


   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710926503






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710654055






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710337186






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709477249






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709465201


   Kubernetes integration test starting
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34451/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709477249


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon commented on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
HyukjinKwon commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-712612351


   Merged to master.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710226062


   **[Test build #129904 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129904/testReport)** for PR 30056 at commit [`76330e2`](https://github.com/apache/spark/commit/76330e2a2b27749f652053e793167814ba0eb6e4).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711060962


   Merged build finished. Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on a change in pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on a change in pull request #30056:
URL: https://github.com/apache/spark/pull/30056#discussion_r509465588



##########
File path: sql/catalyst/src/main/scala/org/apache/spark/sql/internal/SQLConf.scala
##########
@@ -2640,6 +2640,20 @@ object SQLConf {
       .checkValues(LegacyBehaviorPolicy.values.map(_.toString))
       .createWithDefault(LegacyBehaviorPolicy.EXCEPTION.toString)
 
+  val LEGACY_PARQUET_INT96_REBASE_MODE_IN_WRITE =
+    buildConf("spark.sql.legacy.parquet.int96RebaseModeInWrite")
+      .internal()
+      .doc("When LEGACY, which is the default, Spark will rebase INT96 timestamps from " +
+        "Proleptic Gregorian calendar to the legacy hybrid (Julian + Gregorian) calendar when " +
+        "writing Parquet files. When CORRECTED, Spark will not do rebase and write the timestamps" +
+        " as it is. When EXCEPTION, Spark will fail the writing if it sees ancient timestamps " +
+        "that are ambiguous between the two calendars.")
+      .version("3.1.0")
+      .stringConf
+      .transform(_.toUpperCase(Locale.ROOT))
+      .checkValues(LegacyBehaviorPolicy.values.map(_.toString))
+      .createWithDefault(LegacyBehaviorPolicy.LEGACY.toString)

Review comment:
       Here is the PR https://github.com/apache/spark/pull/30121 . Will see how many tests this will affect.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711045795






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710988495


   Kubernetes integration test status failure
   URL: https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder-K8s/34552/
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709606858






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711138314






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-710988544


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34552/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] SparkQA commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
SparkQA commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709471787


   **[Test build #129848 has started](https://amplab.cs.berkeley.edu/jenkins/job/SparkPullRequestBuilder/129848/testReport)** for PR 30056 at commit [`4f62e27`](https://github.com/apache/spark/commit/4f62e271f91318607baec264ac53560da502763a).


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711036670






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins removed a comment on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709477256


   Test FAILed.
   Refer to this link for build results (access rights to CI server needed): 
   https://amplab.cs.berkeley.edu/jenkins//job/SparkPullRequestBuilder-K8s/34451/
   Test FAILed.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] HyukjinKwon removed a comment on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
HyukjinKwon removed a comment on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-712610574


   @cloud-fan can you take a look too just for doubly sure?


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] MaxGekk commented on pull request #30056: [SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
MaxGekk commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-711133549


   @cloud-fan @tomvanbussel @ala @mswit-databricks @HyukjinKwon @bart-samwel May I ask you to review this PR.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org

[GitHub] [spark] AmplabJenkins commented on pull request #30056: [WIP][SPARK-33160][SQL] Allow saving/loading INT96 in parquet w/o rebasing

Posted by GitBox <gi...@apache.org>.
AmplabJenkins commented on pull request #30056:
URL: https://github.com/apache/spark/pull/30056#issuecomment-709380699






----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org