You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@grails.apache.org by "borinquenkid (via GitHub)" <gi...@apache.org> on 2026/10/05 14:44:27 UTC
[PR] Hibernate 7: apply comment, defaultValue, read and write to enum columns [grails-core]
borinquenkid opened a new pull request, #16524:
URL: https://github.com/apache/grails-core/pull/16524
## Problem
`EnumTypeBinder` never applied the column `comment`, `defaultValue`, `read` and `write` that `ColumnBinder` applies to every other column, so the DDL silently lacked them for enum properties.
## Fix
Apply them from the first `ColumnConfig` inside the existing non-empty-columns branch, as `ColumnBinder` does.
## Tests
Three new `EnumTypeBinderSpec` features (extras on the bound column, unset without a column config, and the H2 `information_schema` default and remarks); two failed before. `cfg.*`, `*Enum*`, `grails.gorm.*`, `org.grails.orm.hibernate.*`: 3040 passed.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hibernate 7: apply comment, defaultValue, read and write to enum columns [grails-core]
Posted by "testlens-app[bot] (via GitHub)" <gi...@apache.org>.
testlens-app[bot] commented on PR #16524:
URL: https://github.com/apache/grails-core/pull/16524#issuecomment-6000389610
## ✅ All tests passed ✅
🏷️ Commit: f0ef8480cfe9e3e7a21e7f505c51d69b01efbfc6
▶️ Tests: 94559 executed
⚪️ Checks: 86/86 completed
---
_Learn more about TestLens at [testlens.app/docs](https://testlens.app/docs/features/pr-comment/)._
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hibernate 7: apply comment, defaultValue, read and write to enum columns [grails-core]
Posted by "borinquenkid (via GitHub)" <gi...@apache.org>.
borinquenkid merged PR #16524:
URL: https://github.com/apache/grails-core/pull/16524
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Hibernate 7: apply comment, defaultValue, read and write to enum columns [grails-core]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #16524:
URL: https://github.com/apache/grails-core/pull/16524#issuecomment-5999270742
## [Codecov](https://app.codecov.io/gh/apache/grails-core/pull/16524?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 59.5432%. Comparing base ([`df80e81`](https://app.codecov.io/gh/apache/grails-core/commit/df80e8128b03c029c6e9b40158d9a9b95c6a8110?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`f0ef848`](https://app.codecov.io/gh/apache/grails-core/commit/f0ef8480cfe9e3e7a21e7f505c51d69b01efbfc6?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 4 commits behind head on 8.0.x.
<details><summary>Additional details and impacted files</summary>
[](https://app.codecov.io/gh/apache/grails-core/pull/16524?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
```diff
@@ Coverage Diff @@
## 8.0.x #16524 +/- ##
==================================================
+ Coverage 59.5377% 59.5432% +0.0055%
- Complexity 25019 25022 +3
==================================================
Files 2175 2175
Lines 108637 108637
Branches 19823 19823
==================================================
+ Hits 64680 64686 +6
+ Misses 35002 34998 -4
+ Partials 8955 8953 -2
```
[see 3 files with indirect coverage changes](https://app.codecov.io/gh/apache/grails-core/pull/16524/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@grails.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org