[GitHub] [dubbo-samples] chickenlj commented on a diff in pull request #763: Refactor dubbo-samples-local

["chickenlj (via GitHub)" <gi...@apache.org>]

chickenlj commented on code in PR #763:
URL: https://github.com/apache/dubbo-samples/pull/763#discussion_r1126262265


##########
2-advanced/dubbo-samples-local/case-configuration.yml:
##########
@@ -17,8 +17,22 @@
 
 # local call through injvm, start test container only
 services:
-  dubbo-samples-local-test:
+  local-provider:

Review Comment:
   The test failed for lacking `zookeeper` configuration.
   
   https://github.com/apache/dubbo-samples/blob/master/1-basic/dubbo-samples-spring-boot/case-configuration.yml#L18



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@dubbo.apache.org
For additional commands, e-mail: notifications-help@dubbo.apache.org