You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@geode.apache.org by GitBox <gi...@apache.org> on 2020/08/19 16:02:57 UTC

[GitHub] [geode-native] pivotal-jbarrett commented on pull request #635: GEODE-8436: Several threads calling PdxInstanceFactory::create() causes seg fault

pivotal-jbarrett commented on pull request #635:
URL: https://github.com/apache/geode-native/pull/635#issuecomment-676515632


   > Hi @pdxcodemonkey , @pivotal-jbarrett , @moleske . I have not been able to create a test case that fails every time it is executed. Without the fix, the test case I have implemented fails 70-80% of executions. And with the fix, I have not seen it fail yet. Do you think it would be enough to approve the PR?
   
   Yes, I am fine with it. It's pretty clear when you do that math that the original code is wrong from a concurrency standpoint. Good find!


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org