You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by GitBox <gi...@apache.org> on 2021/12/15 22:04:06 UTC
[GitHub] [pinot] walterddr opened a new pull request #7911: add other reducer
walterddr opened a new pull request #7911:
URL: https://github.com/apache/pinot/pull/7911
## Description
<!-- Add a description of your PR here.
A good description should include pointers to an issue or design document, etc.
-->
## Upgrade Notes
Does this PR prevent a zero down-time upgrade? (Assume upgrade order: Controller, Broker, Server, Minion)
* [ ] Yes (Please label as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR fix a zero-downtime upgrade introduced earlier?
* [ ] Yes (Please label this as **<code>backward-incompat</code>**, and complete the section below on Release Notes)
Does this PR otherwise need attention when creating release notes? Things to consider:
- New configuration options
- Deprecation of configurations
- Signature changes to public methods/interfaces
- New plugins added or old plugins removed
* [ ] Yes (Please label this PR as **<code>release-notes</code>** and complete the section on Release Notes)
## Release Notes
<!-- If you have tagged this as either backward-incompat or release-notes,
you MUST add text here that you would like to see appear in release notes of the
next release. -->
<!-- If you have a series of commits adding or enabling a feature, then
add this section only in final commit that marks the feature completed.
Refer to earlier release notes to see examples of text.
-->
## Documentation
<!-- If you have introduced a new feature or configuration, please add it to the documentation as well.
See https://docs.pinot.apache.org/developers/developers-and-contributors/update-document
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7911: add GRPC E2E support for more reducers
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-995270001
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7911](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a5b1dd) into [master](https://codecov.io/gh/apache/pinot/commit/aa2da071a63cc0d8a06c84fd54bc4c9da9c851f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2da07) will **decrease** coverage by `56.99%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7911 +/- ##
=============================================
- Coverage 71.32% 14.33% -57.00%
+ Complexity 4092 80 -4012
=============================================
Files 1589 1555 -34
Lines 82139 80578 -1561
Branches 12270 12083 -187
=============================================
- Hits 58589 11547 -47042
- Misses 19578 68173 +48595
+ Partials 3972 858 -3114
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `14.33% <0.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/GrpcBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvR3JwY0Jyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `12.96% <ø> (-74.08%)` | :arrow_down: |
| [...inot/core/query/reduce/BaseAggregationReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQmFzZUFnZ3JlZ2F0aW9uUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/pinot/core/query/reduce/BaseDistinctReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQmFzZURpc3RpbmN0UmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/pinot/core/query/reduce/BaseGroupByReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQmFzZUdyb3VwQnlSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...che/pinot/core/query/reduce/BaseReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQmFzZVJlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-94.08%)` | :arrow_down: |
| [...g/apache/pinot/core/query/reduce/ReducerUtils.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVkdWNlclV0aWxzLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [.../reduce/datatable/AggregationDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0FnZ3JlZ2F0aW9uRGF0YVRhYmxlUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...re/query/reduce/datatable/BrokerReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0Jyb2tlclJlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | |
| ... and [1283 more](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa2da07...7a5b1dd](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a change in pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#discussion_r771973799
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ResultReducerFactory.java
##########
@@ -68,11 +67,30 @@ public static DataTableReducer getResultReducer(QueryContext queryContext) {
}
public static StreamingReducer getStreamingReducer(QueryContext queryContext) {
- if (!QueryContextUtils.isSelectionQuery(queryContext) || queryContext.getOrderByExpressions() != null) {
- throw new UnsupportedOperationException("Only selection queries are supported");
+ AggregationFunction[] aggregationFunctions = queryContext.getAggregationFunctions();
+ if (aggregationFunctions == null) {
+ if (queryContext.getOrderByExpressions() != null) {
+ throw new UnsupportedOperationException("Only selection queries are supported");
Review comment:
there's select order by, gap-fill group by, and explain plan operator that hasn't been implemented.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-995270001
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7911](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff594f4) into [master](https://codecov.io/gh/apache/pinot/commit/aa2da071a63cc0d8a06c84fd54bc4c9da9c851f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2da07) will **decrease** coverage by `6.69%`.
> The diff coverage is `37.39%`.
[](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7911 +/- ##
============================================
- Coverage 71.32% 64.63% -6.70%
- Complexity 4092 4110 +18
============================================
Files 1589 1554 -35
Lines 82139 80625 -1514
Branches 12270 12087 -183
============================================
- Hits 58589 52115 -6474
- Misses 19578 24798 +5220
+ Partials 3972 3712 -260
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `67.92% <37.39%> (-0.41%)` | :arrow_down: |
| unittests2 | `14.29% <0.00%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/GrpcBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvR3JwY0Jyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `12.96% <ø> (-74.08%)` | :arrow_down: |
| [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `48.00% <0.00%> (-27.00%)` | :arrow_down: |
| [...re/query/reduce/datatable/BrokerReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0Jyb2tlclJlZHVjZVNlcnZpY2UuamF2YQ==) | `81.08% <ø> (ø)` | |
| [...treaming/AggregationDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0FnZ3JlZ2F0aW9uRGF0YVRhYmxlU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/streaming/DistinctDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0Rpc3RpbmN0RGF0YVRhYmxlU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ce/streaming/GroupByDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0dyb3VwQnlEYXRhVGFibGVTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...educe/streaming/SelectionOnlyStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1NlbGVjdGlvbk9ubHlTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...query/reduce/streaming/StreamingReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1N0cmVhbWluZ1JlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...uery/reduce/datatable/GroupByDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0dyb3VwQnlEYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `58.62% <58.62%> (ø)` | |
| ... and [408 more](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa2da07...ff594f4](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter commented on pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-995270001
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7911](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4e480a2) into [master](https://codecov.io/gh/apache/pinot/commit/aa2da071a63cc0d8a06c84fd54bc4c9da9c851f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2da07) will **decrease** coverage by `56.98%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7911 +/- ##
=============================================
- Coverage 71.32% 14.34% -56.99%
+ Complexity 4092 80 -4012
=============================================
Files 1589 1547 -42
Lines 82139 80470 -1669
Branches 12270 12102 -168
=============================================
- Hits 58589 11544 -47045
- Misses 19578 68072 +48494
+ Partials 3972 854 -3118
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `14.34% <0.00%> (-0.01%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [...y/reduce/StreamingAggregationDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvU3RyZWFtaW5nQWdncmVnYXRpb25EYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...uery/reduce/StreamingDistinctDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvU3RyZWFtaW5nRGlzdGluY3REYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...query/reduce/StreamingGroupByDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvU3RyZWFtaW5nR3JvdXBCeURhdGFUYWJsZVJlZHVjZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...re/query/reduce/StreamingSelectionOnlyReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvU3RyZWFtaW5nU2VsZWN0aW9uT25seVJlZHVjZXIuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...ain/java/org/apache/pinot/core/data/table/Key.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL0tleS5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/spi/utils/BooleanUtils.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvdXRpbHMvQm9vbGVhblV0aWxzLmphdmE=) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/data/table/Record.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL3RhYmxlL1JlY29yZC5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [.../java/org/apache/pinot/core/util/GroupByUtils.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS91dGlsL0dyb3VwQnlVdGlscy5qYXZh) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| [...ava/org/apache/pinot/spi/config/table/FSTType.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3Qtc3BpL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcGkvY29uZmlnL3RhYmxlL0ZTVFR5cGUuamF2YQ==) | `0.00% <0.00%> (-100.00%)` | :arrow_down: |
| ... and [1263 more](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa2da07...4e480a2](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7911: add GRPC E2E support for more reducers
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-995270001
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7911](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a5b1dd) into [master](https://codecov.io/gh/apache/pinot/commit/aa2da071a63cc0d8a06c84fd54bc4c9da9c851f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2da07) will **decrease** coverage by `0.29%`.
> The diff coverage is `63.86%`.
[](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7911 +/- ##
============================================
- Coverage 71.32% 71.03% -0.30%
- Complexity 4092 4112 +20
============================================
Files 1589 1600 +11
Lines 82139 82449 +310
Branches 12270 12285 +15
============================================
- Hits 58589 58566 -23
- Misses 19578 19928 +350
+ Partials 3972 3955 -17
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `29.01% <56.30%> (-0.24%)` | :arrow_down: |
| integration2 | `27.58% <56.30%> (-0.02%)` | :arrow_down: |
| unittests1 | `68.00% <62.60%> (-0.34%)` | :arrow_down: |
| unittests2 | `14.33% <0.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/GrpcBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvR3JwY0Jyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `87.03% <ø> (ø)` | |
| [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `48.00% <0.00%> (-27.00%)` | :arrow_down: |
| [...re/query/reduce/datatable/BrokerReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0Jyb2tlclJlZHVjZVNlcnZpY2UuamF2YQ==) | `97.29% <ø> (ø)` | |
| [.../reduce/streaming/AggregationStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0FnZ3JlZ2F0aW9uU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/streaming/DistinctDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0Rpc3RpbmN0RGF0YVRhYmxlU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ce/streaming/GroupByDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0dyb3VwQnlEYXRhVGFibGVTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...educe/streaming/SelectionOnlyStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1NlbGVjdGlvbk9ubHlTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...query/reduce/streaming/StreamingReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1N0cmVhbWluZ1JlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...duce/datatable/GapFillGroupByDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0dhcEZpbGxHcm91cEJ5RGF0YVRhYmxlUmVkdWNlci5qYXZh) | `79.90% <62.50%> (ø)` | |
| ... and [70 more](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa2da07...7a5b1dd](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a change in pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#discussion_r770193576
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/StreamingAggregationDataTableReducer.java
##########
@@ -0,0 +1,172 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.query.reduce;
+
+import com.google.common.base.Preconditions;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.common.response.broker.AggregationResult;
+import org.apache.pinot.common.response.broker.BrokerResponseNative;
+import org.apache.pinot.common.response.broker.ResultTable;
+import org.apache.pinot.common.utils.DataSchema;
+import org.apache.pinot.common.utils.DataSchema.ColumnDataType;
+import org.apache.pinot.common.utils.DataTable;
+import org.apache.pinot.core.query.aggregation.function.AggregationFunction;
+import org.apache.pinot.core.query.aggregation.function.AggregationFunctionUtils;
+import org.apache.pinot.core.query.request.context.QueryContext;
+import org.apache.pinot.core.transport.ServerRoutingInstance;
+import org.apache.pinot.core.util.QueryOptionsUtils;
+
+
+/**
+ * Helper class to reduce and set Aggregation results into the BrokerResponseNative
+ */
+@SuppressWarnings({"rawtypes", "unchecked"})
+public class StreamingAggregationDataTableReducer implements StreamingReducer {
+ private final QueryContext _queryContext;
+ private final AggregationFunction[] _aggregationFunctions;
+ private final boolean _preserveType;
+ private final int _numAggregationFunctions;
+ private final Object[] _intermediateResults;
+
+ private DataSchema _dataSchema;
+ private DataTableReducerContext _dataTableReducerContext;
+
+ StreamingAggregationDataTableReducer(QueryContext queryContext) {
+ _queryContext = queryContext;
+ _aggregationFunctions = queryContext.getAggregationFunctions();
+ Map<String, String> queryOptions = queryContext.getQueryOptions();
+ _preserveType = QueryOptionsUtils.isPreserveType(queryOptions);
+
+ Preconditions.checkNotNull(_aggregationFunctions);
+ _numAggregationFunctions = _aggregationFunctions.length;
+ _intermediateResults = new Object[_numAggregationFunctions];
+ _dataSchema = null;
+ }
+
+ @Override
+ public void init(DataTableReducerContext dataTableReducerContext) {
+ _dataTableReducerContext = dataTableReducerContext;
+ }
+
+ /**
+ * Reduces data tables and sets aggregations results into
+ * 1. ResultTable if _responseFormatSql is true
+ * 2. AggregationResults by default
+ */
+ @Override
+ public void reduce(ServerRoutingInstance key, DataTable dataTable) {
Review comment:
lol yeah this PR is not ready for review yet. just opening this draft to run CI :-P
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr closed pull request #7911: add GRPC E2E support for more reducers
Posted by GitBox <gi...@apache.org>.
walterddr closed pull request #7911:
URL: https://github.com/apache/pinot/pull/7911
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on pull request #7911: add GRPC E2E support for more reducers
Posted by GitBox <gi...@apache.org>.
walterddr commented on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-1000012120
closing for now. @Jackie-Jiang and I discussed offline and felt like we don't really need the streaming processing in the non-selection-only situation. we will close this and create an issue to track the progress
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
Jackie-Jiang commented on a change in pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#discussion_r770166557
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/ResultReducerFactory.java
##########
@@ -68,11 +67,30 @@ public static DataTableReducer getResultReducer(QueryContext queryContext) {
}
public static StreamingReducer getStreamingReducer(QueryContext queryContext) {
- if (!QueryContextUtils.isSelectionQuery(queryContext) || queryContext.getOrderByExpressions() != null) {
- throw new UnsupportedOperationException("Only selection queries are supported");
+ AggregationFunction[] aggregationFunctions = queryContext.getAggregationFunctions();
+ if (aggregationFunctions == null) {
+ if (queryContext.getOrderByExpressions() != null) {
+ throw new UnsupportedOperationException("Only selection queries are supported");
Review comment:
Selection order-by is still not supported
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/StreamingAggregationDataTableReducer.java
##########
@@ -0,0 +1,172 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.core.query.reduce;
+
+import com.google.common.base.Preconditions;
+import java.io.Serializable;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import java.util.Map;
+import org.apache.pinot.common.response.broker.AggregationResult;
+import org.apache.pinot.common.response.broker.BrokerResponseNative;
+import org.apache.pinot.common.response.broker.ResultTable;
+import org.apache.pinot.common.utils.DataSchema;
+import org.apache.pinot.common.utils.DataSchema.ColumnDataType;
+import org.apache.pinot.common.utils.DataTable;
+import org.apache.pinot.core.query.aggregation.function.AggregationFunction;
+import org.apache.pinot.core.query.aggregation.function.AggregationFunctionUtils;
+import org.apache.pinot.core.query.request.context.QueryContext;
+import org.apache.pinot.core.transport.ServerRoutingInstance;
+import org.apache.pinot.core.util.QueryOptionsUtils;
+
+
+/**
+ * Helper class to reduce and set Aggregation results into the BrokerResponseNative
+ */
+@SuppressWarnings({"rawtypes", "unchecked"})
+public class StreamingAggregationDataTableReducer implements StreamingReducer {
+ private final QueryContext _queryContext;
+ private final AggregationFunction[] _aggregationFunctions;
+ private final boolean _preserveType;
+ private final int _numAggregationFunctions;
+ private final Object[] _intermediateResults;
+
+ private DataSchema _dataSchema;
+ private DataTableReducerContext _dataTableReducerContext;
+
+ StreamingAggregationDataTableReducer(QueryContext queryContext) {
+ _queryContext = queryContext;
+ _aggregationFunctions = queryContext.getAggregationFunctions();
+ Map<String, String> queryOptions = queryContext.getQueryOptions();
+ _preserveType = QueryOptionsUtils.isPreserveType(queryOptions);
+
+ Preconditions.checkNotNull(_aggregationFunctions);
+ _numAggregationFunctions = _aggregationFunctions.length;
+ _intermediateResults = new Object[_numAggregationFunctions];
+ _dataSchema = null;
+ }
+
+ @Override
+ public void init(DataTableReducerContext dataTableReducerContext) {
+ _dataTableReducerContext = dataTableReducerContext;
+ }
+
+ /**
+ * Reduces data tables and sets aggregations results into
+ * 1. ResultTable if _responseFormatSql is true
+ * 2. AggregationResults by default
+ */
+ @Override
+ public void reduce(ServerRoutingInstance key, DataTable dataTable) {
Review comment:
(major) We need to make sure all `reduce()` is thread safe. Same for other streaming reducers.
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/StreamingSelectionOnlyReducer.java
##########
@@ -35,8 +35,8 @@
import org.slf4j.LoggerFactory;
-public class SelectionOnlyStreamingReducer implements StreamingReducer {
- private static final Logger LOGGER = LoggerFactory.getLogger(SelectionOnlyStreamingReducer.class);
+public class StreamingSelectionOnlyReducer implements StreamingReducer {
Review comment:
(minor) I feel the original class name is easier find. If you change the class name to prevent it from mixing into the non-streaming ones, we can move all the streaming reducers one level down under the `streaming` package
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-995270001
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7911](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff594f4) into [master](https://codecov.io/gh/apache/pinot/commit/aa2da071a63cc0d8a06c84fd54bc4c9da9c851f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2da07) will **decrease** coverage by `0.30%`.
> The diff coverage is `37.82%`.
[](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7911 +/- ##
============================================
- Coverage 71.32% 71.02% -0.31%
- Complexity 4092 4110 +18
============================================
Files 1589 1599 +10
Lines 82139 82496 +357
Branches 12270 12290 +20
============================================
+ Hits 58589 58591 +2
- Misses 19578 19954 +376
+ Partials 3972 3951 -21
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `29.05% <34.78%> (-0.20%)` | :arrow_down: |
| integration2 | `27.51% <34.78%> (-0.08%)` | :arrow_down: |
| unittests1 | `67.92% <37.39%> (-0.41%)` | :arrow_down: |
| unittests2 | `14.29% <0.00%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/GrpcBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvR3JwY0Jyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `87.03% <ø> (ø)` | |
| [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `48.00% <0.00%> (-27.00%)` | :arrow_down: |
| [...re/query/reduce/datatable/BrokerReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0Jyb2tlclJlZHVjZVNlcnZpY2UuamF2YQ==) | `97.29% <ø> (ø)` | |
| [...treaming/AggregationDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0FnZ3JlZ2F0aW9uRGF0YVRhYmxlU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/streaming/DistinctDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0Rpc3RpbmN0RGF0YVRhYmxlU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ce/streaming/GroupByDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0dyb3VwQnlEYXRhVGFibGVTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...educe/streaming/SelectionOnlyStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1NlbGVjdGlvbk9ubHlTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...query/reduce/streaming/StreamingReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1N0cmVhbWluZ1JlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...uery/reduce/datatable/GroupByDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0dyb3VwQnlEYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `62.06% <62.06%> (ø)` | |
| ... and [63 more](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa2da07...ff594f4](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-995270001
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7911](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff594f4) into [master](https://codecov.io/gh/apache/pinot/commit/aa2da071a63cc0d8a06c84fd54bc4c9da9c851f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2da07) will **decrease** coverage by `1.15%`.
> The diff coverage is `37.82%`.
[](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7911 +/- ##
============================================
- Coverage 71.32% 70.17% -1.16%
- Complexity 4092 4110 +18
============================================
Files 1589 1599 +10
Lines 82139 82496 +357
Branches 12270 12290 +20
============================================
- Hits 58589 57888 -701
- Misses 19578 20648 +1070
+ Partials 3972 3960 -12
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `29.05% <34.78%> (-0.20%)` | :arrow_down: |
| integration2 | `?` | |
| unittests1 | `67.92% <37.39%> (-0.41%)` | :arrow_down: |
| unittests2 | `14.29% <0.00%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/GrpcBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvR3JwY0Jyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `87.03% <ø> (ø)` | |
| [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `48.00% <0.00%> (-27.00%)` | :arrow_down: |
| [...re/query/reduce/datatable/BrokerReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0Jyb2tlclJlZHVjZVNlcnZpY2UuamF2YQ==) | `97.29% <ø> (ø)` | |
| [...treaming/AggregationDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0FnZ3JlZ2F0aW9uRGF0YVRhYmxlU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/streaming/DistinctDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0Rpc3RpbmN0RGF0YVRhYmxlU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ce/streaming/GroupByDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0dyb3VwQnlEYXRhVGFibGVTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...educe/streaming/SelectionOnlyStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1NlbGVjdGlvbk9ubHlTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...query/reduce/streaming/StreamingReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1N0cmVhbWluZ1JlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...uery/reduce/datatable/GroupByDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0dyb3VwQnlEYXRhVGFibGVSZWR1Y2VyLmphdmE=) | `62.06% <62.06%> (ø)` | |
| ... and [133 more](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa2da07...ff594f4](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-995270001
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7911](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (ff594f4) into [master](https://codecov.io/gh/apache/pinot/commit/aa2da071a63cc0d8a06c84fd54bc4c9da9c851f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2da07) will **decrease** coverage by `57.03%`.
> The diff coverage is `0.00%`.
[](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7911 +/- ##
=============================================
- Coverage 71.32% 14.29% -57.04%
+ Complexity 4092 80 -4012
=============================================
Files 1589 1554 -35
Lines 82139 80625 -1514
Branches 12270 12087 -183
=============================================
- Hits 58589 11527 -47062
- Misses 19578 68241 +48663
+ Partials 3972 857 -3115
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `?` | |
| integration2 | `?` | |
| unittests1 | `?` | |
| unittests2 | `14.29% <0.00%> (-0.06%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/GrpcBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvR3JwY0Jyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `12.96% <ø> (-74.08%)` | :arrow_down: |
| [...inot/core/query/reduce/AggregationReducerBase.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQWdncmVnYXRpb25SZWR1Y2VyQmFzZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...che/pinot/core/query/reduce/BaseReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvQmFzZVJlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (-94.08%)` | :arrow_down: |
| [...e/pinot/core/query/reduce/DistinctReducerBase.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvRGlzdGluY3RSZWR1Y2VyQmFzZS5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...he/pinot/core/query/reduce/GroupByReducerBase.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvR3JvdXBCeVJlZHVjZXJCYXNlLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `0.00% <0.00%> (-75.00%)` | :arrow_down: |
| [.../reduce/datatable/AggregationDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0FnZ3JlZ2F0aW9uRGF0YVRhYmxlUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...re/query/reduce/datatable/BrokerReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0Jyb2tlclJlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <ø> (ø)` | |
| [...ery/reduce/datatable/DistinctDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0Rpc3RpbmN0RGF0YVRhYmxlUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| ... and [1281 more](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa2da07...ff594f4](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] walterddr commented on a change in pull request #7911: add full GRPC E2E support
Posted by GitBox <gi...@apache.org>.
walterddr commented on a change in pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#discussion_r771973692
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/query/reduce/StreamingSelectionOnlyReducer.java
##########
@@ -35,8 +35,8 @@
import org.slf4j.LoggerFactory;
-public class SelectionOnlyStreamingReducer implements StreamingReducer {
- private static final Logger LOGGER = LoggerFactory.getLogger(SelectionOnlyStreamingReducer.class);
+public class StreamingSelectionOnlyReducer implements StreamingReducer {
Review comment:
done
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
[GitHub] [pinot] codecov-commenter edited a comment on pull request #7911: add GRPC E2E support for more reducers
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #7911:
URL: https://github.com/apache/pinot/pull/7911#issuecomment-995270001
# [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#7911](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (7a5b1dd) into [master](https://codecov.io/gh/apache/pinot/commit/aa2da071a63cc0d8a06c84fd54bc4c9da9c851f0?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (aa2da07) will **decrease** coverage by `1.14%`.
> The diff coverage is `63.86%`.
[](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #7911 +/- ##
============================================
- Coverage 71.32% 70.17% -1.15%
- Complexity 4092 4112 +20
============================================
Files 1589 1600 +11
Lines 82139 82449 +310
Branches 12270 12285 +15
============================================
- Hits 58589 57862 -727
- Misses 19578 20629 +1051
+ Partials 3972 3958 -14
```
| Flag | Coverage Δ | |
|---|---|---|
| integration1 | `29.01% <56.30%> (-0.24%)` | :arrow_down: |
| integration2 | `?` | |
| unittests1 | `68.00% <62.60%> (-0.34%)` | :arrow_down: |
| unittests2 | `14.33% <0.00%> (-0.03%)` | :arrow_down: |
Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#carryforward-flags-in-the-pull-request-comment) to find out more.
| [Impacted Files](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...roker/requesthandler/GrpcBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvR3JwY0Jyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `0.00% <ø> (ø)` | |
| [...thandler/SingleConnectionBrokerRequestHandler.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvU2luZ2xlQ29ubmVjdGlvbkJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=) | `87.03% <ø> (ø)` | |
| [.../pinot/core/query/reduce/ResultReducerFactory.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvUmVzdWx0UmVkdWNlckZhY3RvcnkuamF2YQ==) | `48.00% <0.00%> (-27.00%)` | :arrow_down: |
| [...re/query/reduce/datatable/BrokerReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0Jyb2tlclJlZHVjZVNlcnZpY2UuamF2YQ==) | `97.29% <ø> (ø)` | |
| [.../reduce/streaming/AggregationStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0FnZ3JlZ2F0aW9uU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...e/streaming/DistinctDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0Rpc3RpbmN0RGF0YVRhYmxlU3RyZWFtaW5nUmVkdWNlci5qYXZh) | `0.00% <0.00%> (ø)` | |
| [...ce/streaming/GroupByDataTableStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL0dyb3VwQnlEYXRhVGFibGVTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...educe/streaming/SelectionOnlyStreamingReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1NlbGVjdGlvbk9ubHlTdHJlYW1pbmdSZWR1Y2VyLmphdmE=) | `0.00% <0.00%> (ø)` | |
| [...query/reduce/streaming/StreamingReduceService.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2Uvc3RyZWFtaW5nL1N0cmVhbWluZ1JlZHVjZVNlcnZpY2UuamF2YQ==) | `0.00% <0.00%> (ø)` | |
| [...duce/datatable/GapFillGroupByDataTableReducer.java](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9xdWVyeS9yZWR1Y2UvZGF0YXRhYmxlL0dhcEZpbGxHcm91cEJ5RGF0YVRhYmxlUmVkdWNlci5qYXZh) | `79.90% <62.50%> (ø)` | |
| ... and [142 more](https://codecov.io/gh/apache/pinot/pull/7911/diff?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [aa2da07...7a5b1dd](https://codecov.io/gh/apache/pinot/pull/7911?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org