You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@shardingsphere.apache.org by GitBox <gi...@apache.org> on 2020/11/11 12:34:12 UTC
[GitHub] [shardingsphere-elasticjob] TeslaCN opened a new pull request #1709: Unify dependencies' version and exclude unnecessary dependencies
TeslaCN opened a new pull request #1709:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1709
Fixes #1707
Changes proposed in this pull request:
- Unify Netty version to 4.1.45.Final (Consistent with Netty version in Curator 5.1.0).
- Add jul-to-slf4j to dependencyManagement.
- Exclude unused junit jupiter, junit vintage from Spring Boot Starter.
- Add commons-pool to dependencyManagement.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] codecov-io commented on pull request #1709: Unify dependencies' version and exclude unnecessary dependencies
Posted by GitBox <gi...@apache.org>.
codecov-io commented on pull request #1709:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1709#issuecomment-725430992
# [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1709?src=pr&el=h1) Report
> Merging [#1709](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1709?src=pr&el=desc) (36038cd) into [master](https://codecov.io/gh/apache/shardingsphere-elasticjob/commit/b21485497746011fd1c4b2fc3d35d0972af82d42?el=desc) (b214854) will **decrease** coverage by `0.01%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1709?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #1709 +/- ##
============================================
- Coverage 86.07% 86.06% -0.02%
Complexity 106 106
============================================
Files 252 252
Lines 5682 5682
Branches 878 878
============================================
- Hits 4891 4890 -1
Misses 477 477
- Partials 314 315 +1
```
| [Impacted Files](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1709?src=pr&el=tree) | Coverage Δ | Complexity Δ | |
|---|---|---|---|
| [...ticjob/lite/internal/snapshot/SnapshotService.java](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1709/diff?src=pr&el=tree#diff-ZWxhc3RpY2pvYi1saXRlL2VsYXN0aWNqb2ItbGl0ZS1jb3JlL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9zaGFyZGluZ3NwaGVyZS9lbGFzdGljam9iL2xpdGUvaW50ZXJuYWwvc25hcHNob3QvU25hcHNob3RTZXJ2aWNlLmphdmE=) | `80.95% <0.00%> (-1.59%)` | `1.00% <0.00%> (ø%)` | |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1709?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1709?src=pr&el=footer). Last update [b214854...36038cd](https://codecov.io/gh/apache/shardingsphere-elasticjob/pull/1709?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [shardingsphere-elasticjob] Technoboy- merged pull request #1709: Unify dependencies' version and exclude unnecessary dependencies
Posted by GitBox <gi...@apache.org>.
Technoboy- merged pull request #1709:
URL: https://github.com/apache/shardingsphere-elasticjob/pull/1709
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org