You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Attila Bukor (Code Review)" <ge...@cloudera.org> on 2021/11/16 17:14:21 UTC

[kudu-CR] [tests] Add iteration to test dir path 

Hello Alexey Serbin, Andrew Wong,

I'd like you to do a code review. Please visit

    http://gerrit.cloudera.org:8080/18030

to review the following change.


Change subject: [tests] Add iteration to test dir path
......................................................................

[tests] Add iteration to test dir path

GTest supports running tests repeatedly by setting a "--gtest_repeat"
flag, which can be incredibly useful to debug flaky tests when using
together with "--gtest_break_on_failure" in gdb.

Unfortunately, most of our tests expect an empty data directory, but the
test directory was the same across repeated runs without being emptied.

Adding the iteration number to the end of the directory solves this
problem and --gtest_repeat can be used safely.

Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
---
M src/kudu/util/test_main.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
3 files changed, 23 insertions(+), 7 deletions(-)



  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/18030/1
-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 1
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 4: Verified+1

Random flaky test failures


-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 20:45:10 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 3: Code-Review+2

(2 comments)

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc@159
PS3, Line 159: else {
             :     VLOG(1) << "Cleaning up temporary test files...";
             :     WARN_NOT_OK(env_->DeleteRecursively(test_dir_),
             :                 "Couldn't remove test files");
             :   }
> IIUC, a new instance of KuduTest is created for each iteration.  Otherwise,
Ah, makes sense. I hadn't considered the context of looking at both successful and failed runs' logs.


http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc@236
PS3, Line 236: 600"
nit: should be updated



-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 19:48:35 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has removed a vote on this change.

Change subject: [tests] Add iteration to test dir path
......................................................................


Removed Verified-1 by Kudu Jenkins (120)
-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: deleteVote
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18030

to look at the new patch set (#4).

Change subject: [tests] Add iteration to test dir path
......................................................................

[tests] Add iteration to test dir path

GTest supports running tests repeatedly by setting a "--gtest_repeat"
flag, which can be incredibly useful to debug flaky tests when using
together with "--gtest_break_on_failure" in gdb.

Unfortunately, most of our tests expect an empty data directory, but the
test directory was the same across repeated runs without being emptied.

Adding the iteration number to the end of the directory solves this
problem and --gtest_repeat can be used safely.

Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
---
M src/kudu/util/test_main.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
3 files changed, 22 insertions(+), 6 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/18030/4
-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 20:01:16 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc@159
PS3, Line 159: else {
             :     VLOG(1) << "Cleaning up temporary test files...";
             :     WARN_NOT_OK(env_->DeleteRecursively(test_dir_),
             :                 "Couldn't remove test files");
             :   }
> I guess it does, but not if there are fatal failures or if you always leave
IIUC, a new instance of KuduTest is created for each iteration.  Otherwise, using test_dir_ and GetTestDataDirectory() would result in unexpected inconsistencies.

However, if --test_leave_files is set or a test fails sometimes, the directory isn't removed.  Not a big deal if running the test interactively, but if thinking about scheduling a run using --gtest_repeat, the newly introduced functionality comes handy.



-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 19:40:59 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18030

to look at the new patch set (#2).

Change subject: [tests] Add iteration to test dir path
......................................................................

[tests] Add iteration to test dir path

GTest supports running tests repeatedly by setting a "--gtest_repeat"
flag, which can be incredibly useful to debug flaky tests when using
together with "--gtest_break_on_failure" in gdb.

Unfortunately, most of our tests expect an empty data directory, but the
test directory was the same across repeated runs without being emptied.

Adding the iteration number to the end of the directory solves this
problem and --gtest_repeat can be used safely.

Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
---
M src/kudu/util/test_main.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
3 files changed, 24 insertions(+), 7 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/18030/2
-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 2
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc@159
PS3, Line 159: else {
             :     VLOG(1) << "Cleaning up temporary test files...";
             :     WARN_NOT_OK(env_->DeleteRecursively(test_dir_),
             :                 "Couldn't remove test files");
             :   }
> I'm surprised this wouldn't clean the directory. Is the same KuduTest reuse
I guess it does, but not if there are fatal failures or if you always leave files, which can still be valuable if you want to compare files between successful and unsuccessful runs.



-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 19:15:58 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 4: Code-Review+2


-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 20:27:25 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Hello Tidy Bot, Alexey Serbin, Kudu Jenkins, Andrew Wong, 

I'd like you to reexamine a change. Please visit

    http://gerrit.cloudera.org:8080/18030

to look at the new patch set (#3).

Change subject: [tests] Add iteration to test dir path
......................................................................

[tests] Add iteration to test dir path

GTest supports running tests repeatedly by setting a "--gtest_repeat"
flag, which can be incredibly useful to debug flaky tests when using
together with "--gtest_break_on_failure" in gdb.

Unfortunately, most of our tests expect an empty data directory, but the
test directory was the same across repeated runs without being emptied.

Adding the iteration number to the end of the directory solves this
problem and --gtest_repeat can be used safely.

Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
---
M src/kudu/util/test_main.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
3 files changed, 20 insertions(+), 5 deletions(-)


  git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/30/18030/3
-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Andrew Wong (Code Review)" <ge...@cloudera.org>.
Andrew Wong has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 3:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc@159
PS3, Line 159: else {
             :     VLOG(1) << "Cleaning up temporary test files...";
             :     WARN_NOT_OK(env_->DeleteRecursively(test_dir_),
             :                 "Couldn't remove test files");
             :   }
I'm surprised this wouldn't clean the directory. Is the same KuduTest reused across repetitions?



-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 18:57:11 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Alexey Serbin (Code Review)" <ge...@cloudera.org>.
Alexey Serbin has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 3: Code-Review+2

That's a cool extra!  LGTM.


-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 3
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 18:46:25 +0000
Gerrit-HasComments: No

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has posted comments on this change. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................


Patch Set 4:

(1 comment)

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc
File src/kudu/util/test_util.cc:

http://gerrit.cloudera.org:8080/#/c/18030/3/src/kudu/util/test_util.cc@236
PS3, Line 236: 
> nit: should be updated
Done



-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 4
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)
Gerrit-Comment-Date: Tue, 16 Nov 2021 19:55:13 +0000
Gerrit-HasComments: Yes

[kudu-CR] [tests] Add iteration to test dir path

Posted by "Attila Bukor (Code Review)" <ge...@cloudera.org>.
Attila Bukor has submitted this change and it was merged. ( http://gerrit.cloudera.org:8080/18030 )

Change subject: [tests] Add iteration to test dir path
......................................................................

[tests] Add iteration to test dir path

GTest supports running tests repeatedly by setting a "--gtest_repeat"
flag, which can be incredibly useful to debug flaky tests when using
together with "--gtest_break_on_failure" in gdb.

Unfortunately, most of our tests expect an empty data directory, but the
test directory was the same across repeated runs without being emptied.

Adding the iteration number to the end of the directory solves this
problem and --gtest_repeat can be used safely.

Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Reviewed-on: http://gerrit.cloudera.org:8080/18030
Reviewed-by: Andrew Wong <aw...@cloudera.com>
Reviewed-by: Alexey Serbin <as...@cloudera.com>
Tested-by: Attila Bukor <ab...@apache.org>
---
M src/kudu/util/test_main.cc
M src/kudu/util/test_util.cc
M src/kudu/util/test_util.h
3 files changed, 22 insertions(+), 6 deletions(-)

Approvals:
  Andrew Wong: Looks good to me, approved
  Alexey Serbin: Looks good to me, approved
  Attila Bukor: Verified

-- 
To view, visit http://gerrit.cloudera.org:8080/18030
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings

Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: merged
Gerrit-Change-Id: I175756e6f758246f2234eae3a0ad99a544f80026
Gerrit-Change-Number: 18030
Gerrit-PatchSet: 5
Gerrit-Owner: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Alexey Serbin <as...@cloudera.com>
Gerrit-Reviewer: Andrew Wong <aw...@cloudera.com>
Gerrit-Reviewer: Attila Bukor <ab...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Tidy Bot (241)