You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@geode.apache.org by anilkumar gingade <ag...@pivotal.io> on 2017/08/17 23:20:36 UTC
Review Request 61722: GEODE-3047 Atomic creation flag is not set if
the region is recoverd from the disk.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61722/
-----------------------------------------------------------
Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick Reich.
Repository: geode
Description
-------
While creating bucket region, to satisfy the redudndancy copies the bucket regions
are created on all vailable nodes. The initialization (setting persistentIDs) of
these buckets are done after creating buckets on all the nodes. This introduced
a race condition for the bucket region which are recovered from the disk to
exchange thier old id with the peer node resulting in ConflictingPersistentData
Exception.
The changes are done so that the regions persistent ids are set as soon as they
are created/initialized.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/BucketPersistenceAdvisor.java 367bb75e9
geode-core/src/test/java/org/apache/geode/internal/cache/BucketPersistenceAdvisorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/61722/diff/1/
Testing
-------
added new unit test.
run PartitionedRegionSingleHopDUnitTest.testClientMetadataForPersistentPrs 1400 times
Thanks,
anilkumar gingade
Re: Review Request 61722: GEODE-3047 Atomic creation flag is not set
if the region is recoverd from the disk.
Posted by Nick Reich <nr...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61722/#review183187
-----------------------------------------------------------
Ship it!
Ship It!
- Nick Reich
On Aug. 17, 2017, 11:20 p.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61722/
> -----------------------------------------------------------
>
> (Updated Aug. 17, 2017, 11:20 p.m.)
>
>
> Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick Reich.
>
>
> Repository: geode
>
>
> Description
> -------
>
> While creating bucket region, to satisfy the redudndancy copies the bucket regions
> are created on all vailable nodes. The initialization (setting persistentIDs) of
> these buckets are done after creating buckets on all the nodes. This introduced
> a race condition for the bucket region which are recovered from the disk to
> exchange thier old id with the peer node resulting in ConflictingPersistentData
> Exception.
>
> The changes are done so that the regions persistent ids are set as soon as they
> are created/initialized.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/BucketPersistenceAdvisor.java 367bb75e9
> geode-core/src/test/java/org/apache/geode/internal/cache/BucketPersistenceAdvisorTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61722/diff/1/
>
>
> Testing
> -------
>
> added new unit test.
> run PartitionedRegionSingleHopDUnitTest.testClientMetadataForPersistentPrs 1400 times
>
>
> Thanks,
>
> anilkumar gingade
>
>
Re: Review Request 61722: GEODE-3047 Atomic creation flag is not set
if the region is recoverd from the disk.
Posted by Darrel Schneider <ds...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61722/#review183507
-----------------------------------------------------------
Ship it!
Ship It!
- Darrel Schneider
On Aug. 18, 2017, 9:58 a.m., anilkumar gingade wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/61722/
> -----------------------------------------------------------
>
> (Updated Aug. 18, 2017, 9:58 a.m.)
>
>
> Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick Reich.
>
>
> Repository: geode
>
>
> Description
> -------
>
> While creating bucket region, to satisfy the redudndancy copies the bucket regions
> are created on all available nodes. The initialization (setting persistentIDs) of
> these buckets are done after creating buckets on all the nodes. This introduced
> a race condition for the bucket region which are recovered from the disk to
> exchange thier old id with the peer node resulting in ConflictingPersistentData
> Exception.
>
> The changes are done so that the regions persistent ids are set as soon as they
> are created/initialized.
>
>
> Diffs
> -----
>
> geode-core/src/main/java/org/apache/geode/internal/cache/BucketPersistenceAdvisor.java 367bb75e9
> geode-core/src/test/java/org/apache/geode/internal/cache/BucketPersistenceAdvisorTest.java PRE-CREATION
>
>
> Diff: https://reviews.apache.org/r/61722/diff/1/
>
>
> Testing
> -------
>
> added new unit test.
> run PartitionedRegionSingleHopDUnitTest.testClientMetadataForPersistentPrs 1400 times
>
>
> Thanks,
>
> anilkumar gingade
>
>
Re: Review Request 61722: GEODE-3047 Atomic creation flag is not set
if the region is recoverd from the disk.
Posted by anilkumar gingade <ag...@pivotal.io>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/61722/
-----------------------------------------------------------
(Updated Aug. 18, 2017, 4:58 p.m.)
Review request for geode, Darrel Schneider, Eric Shu, Lynn Gallinat, and Nick Reich.
Repository: geode
Description (updated)
-------
While creating bucket region, to satisfy the redudndancy copies the bucket regions
are created on all available nodes. The initialization (setting persistentIDs) of
these buckets are done after creating buckets on all the nodes. This introduced
a race condition for the bucket region which are recovered from the disk to
exchange thier old id with the peer node resulting in ConflictingPersistentData
Exception.
The changes are done so that the regions persistent ids are set as soon as they
are created/initialized.
Diffs
-----
geode-core/src/main/java/org/apache/geode/internal/cache/BucketPersistenceAdvisor.java 367bb75e9
geode-core/src/test/java/org/apache/geode/internal/cache/BucketPersistenceAdvisorTest.java PRE-CREATION
Diff: https://reviews.apache.org/r/61722/diff/1/
Testing
-------
added new unit test.
run PartitionedRegionSingleHopDUnitTest.testClientMetadataForPersistentPrs 1400 times
Thanks,
anilkumar gingade