[GitHub] [iceberg] Fokko commented on a change in pull request #2012: Fix small issues

[GitBox <gi...@apache.org>]

Fokko commented on a change in pull request #2012:
URL: https://github.com/apache/iceberg/pull/2012#discussion_r551582770



##########
File path: core/src/main/java/org/apache/iceberg/ScanSummary.java
##########
@@ -305,7 +305,7 @@ public String toString() {
   private static class TopN<K, V> {
     private final int maxSize;
     private final boolean throwIfLimited;
-    private final SortedMap<K, V> map;
+    private final NavigableMap<K, V> map;

Review comment:
       Great question. This one triggered me:
   ```
   /Users/fokkodriesprong/Desktop/incubator-iceberg/core/src/main/java/org/apache/iceberg/ScanSummary.java:326: warning: [JdkObsolete] SortedMap was replaced by NavigableMap in Java 6.
         map.put(key, updateFunc.apply(map.get(key)));
                ^
       (see https://errorprone.info/bugpattern/JdkObsolete)
   ```
   The SortedMap has been superseded by the NavigableMap. According to the author, there are some issues with the sorted set API: https://www.youtube.com/watch?v=aAb7hSCtvGw#t=1258 I agree that in this case, it doesn't really matter.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org