[GitHub] [ozone] smengcl commented on a diff in pull request #3820: HDDS-7309. Enable by default GRPC between S3G and OM

[GitBox <gi...@apache.org>]

smengcl commented on code in PR #3820:
URL: https://github.com/apache/ozone/pull/3820#discussion_r1007723289


##########
hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java:
##########
@@ -66,6 +66,7 @@ public void initializeMemberVariables() {
     xmlPrefixToSkipCompare.add("ipc.client.rpc-timeout.ms");
     xmlPropsToSkipCompare.add("ozone.om.leader.election.minimum.timeout" +
         ".duration"); // Deprecated config
+    xmlPropsToSkipCompare.add("ozone.om.transport.class");

Review Comment:
   You probably want to delete this line:
   
   https://github.com/apache/ozone/blob/a66e43e2838f087229cb4b0fac1e1dc969ab80dd/hadoop-ozone/integration-test/src/test/java/org/apache/hadoop/ozone/TestOzoneConfigurationFields.java#L103
   
   rather than adding this to skip set?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@ozone.apache.org
For additional commands, e-mail: issues-help@ozone.apache.org