You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@helix.apache.org by "desaikomal (via GitHub)" <gi...@apache.org> on 2023/02/24 00:47:20 UTC
[GitHub] [helix] desaikomal opened a new pull request, #2384: Use JDK 11 for Helix Project
desaikomal opened a new pull request, #2384:
URL: https://github.com/apache/helix/pull/2384
### Issues
- [ ] My PR addresses the following Helix issues and references them in the PR description:
### Description
Helix has been using JDK 1.8. We want to move to latest JDK but prior to that, we can use JDK11 as intermediate step. This will help us remain current and use all the language optimizations for performance improvements.
### Tests
- The following is the result of the "mvn test" command on the appropriate module:
[ERROR] Failures:
[ERROR] TestNoThrottleDisabledPartitions.testDisablingTopStateReplicaByDisablingInstance:98 expected:<false> but was:<true>
[ERROR] TestNoThrottleDisabledPartitions.testNoThrottleOnDisabledInstance:231->setupEnvironment:317->setupCluster:436 » ZkClient
[ERROR] TestP2PNoDuplicatedMessage.testP2PStateTransitionEnabled:180 expected:<true> but was:<false>
[ERROR] TestMultiZkConnectionConfig>MultiZkTestBase.afterClass:137 expected:<true> but was:<false>
[ERROR] TestMultiZkConnectionConfig.testZKHelixManager:295->Object.wait:328->Object.wait:-2 » ThreadTimeout
[ERROR] TestWagedRebalanceFaultZone.testAddZone:270->validate:318->validateZoneAndTagIsolation:342 expected:<3> but was:<2>
[ERROR] TestTaskStateModelFactory.testZkClientCreationMultiZk:80 » Bind Address alread...
[INFO]
[ERROR] Tests run: 1325, Failures: 7, Errors: 0, Skipped: 6
I ran all the 7 failures as independent test-runs. Some tests passed on running while some failed. I took a fresh code branch with no changes and ran the same failed tests against it and they failed there as well. So between re-run and clean branch, there are NO NEW failures.
### Changes that Break Backward Compatibility (Optional)
- My PR contains changes that break backward compatibility or previous assumptions for certain methods or API. They include:
(Consider including all behavior changes for public methods or API. Also include these changes in merge description so that other developers are aware of these changes. This allows them to make relevant code changes in feature branches accounting for the new method/API behavior.)
### Documentation (Optional)
- In case of new functionality, my PR adds documentation in the following wiki page:
(Link the GitHub wiki you added)
### Commits
- My commits all reference appropriate Apache Helix GitHub issues in their subject lines. In addition, my commits follow the guidelines from "[How to write a good git commit message](http://chris.beams.io/posts/git-commit/)":
1. Subject is separated from body by a blank line
1. Subject is limited to 50 characters (not including Jira issue reference)
1. Subject does not end with a period
1. Subject uses the imperative mood ("add", not "adding")
1. Body wraps at 72 characters
1. Body explains "what" and "why", not "how"
### Code Quality
- My diff has been formatted using helix-style.xml
(helix-style-intellij.xml if IntelliJ IDE is used)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rahulrane50 commented on a diff in pull request #2384: Use JDK 11 for Helix Project
Posted by "rahulrane50 (via GitHub)" <gi...@apache.org>.
rahulrane50 commented on code in PR #2384:
URL: https://github.com/apache/helix/pull/2384#discussion_r1120572590
##########
helix-rest/src/main/java/org/apache/helix/rest/server/HelixRestServer.java:
##########
@@ -283,7 +283,8 @@ private void cleanupResourceConfigs() {
}
}
- public void setupSslServer(int port, SslContextFactory sslContextFactory) {
+
+ public void setupSslServer(int port, SslContextFactory.Server sslContextFactory) {
Review Comment:
Neat : If Now parent factory class is deprecated and directly server and client class are encouraged to access then should we rename this variable as well to "sslContextServer"? Also may be update documentation/comments here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] qqu0127 commented on a diff in pull request #2384: Use JDK 11 for Helix Project
Posted by "qqu0127 (via GitHub)" <gi...@apache.org>.
qqu0127 commented on code in PR #2384:
URL: https://github.com/apache/helix/pull/2384#discussion_r1120413060
##########
.github/workflows/Helix-PR-CI.yml:
##########
@@ -14,14 +14,14 @@ jobs:
steps:
- uses: actions/checkout@v2
- - name: Set up JDK 1.8
+ - name: Set up JDK 11
uses: actions/setup-java@v1
with:
- java-version: 1.8
+ java-version: 11
- name: Build with Maven
- run: mvn clean install -Dmaven.test.skip.exec=true -DretryFailedDeploymentCount=5
+ run: mvn clean install -Dmaven.test.skip.exec=true
- name: Run All Tests
- run: mvn -q -fae -Dsurefire.rerunFailingTestsCount=5 test
+ run: mvn -q -fae test
Review Comment:
Is this intended?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2384: Use JDK 11 for Helix Project
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2384:
URL: https://github.com/apache/helix/pull/2384#issuecomment-1448323477
JDK11 - optimization work can start once we have the base line.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on pull request #2384: Use JDK 11 for Helix Project
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on PR #2384:
URL: https://github.com/apache/helix/pull/2384#issuecomment-1448809258
Thank you all (@junkaixue , @mgao0 , @rahulrane50 , @qqu0127 ) for the review.
Change has been approved by @junkaixue , @mgao0 , @rahulrane50 and @qqu0127. Commit message : Upgrading Helix to use JDK 11.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rahulrane50 commented on a diff in pull request #2384: Use JDK 11 for Helix Project
Posted by "rahulrane50 (via GitHub)" <gi...@apache.org>.
rahulrane50 commented on code in PR #2384:
URL: https://github.com/apache/helix/pull/2384#discussion_r1117748892
##########
.github/workflows/Helix-CI.yml:
##########
@@ -12,14 +12,14 @@ jobs:
steps:
- uses: actions/checkout@v2
- - name: Set up JDK 1.8
+ - name: Set up JDK 11
uses: actions/setup-java@v1
with:
- java-version: 1.8
+ java-version: 11
- name: Build with Maven
- run: mvn clean install -Dmaven.test.skip.exec=true -DretryFailedDeploymentCount=5
Review Comment:
May I ask any reason for removing this "re-run failed tests" flag?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] rahulrane50 commented on pull request #2384: Use JDK 11 for Helix Project
Posted by "rahulrane50 (via GitHub)" <gi...@apache.org>.
rahulrane50 commented on PR #2384:
URL: https://github.com/apache/helix/pull/2384#issuecomment-1444601085
Not an expert here but just curious don't we need fe other changes like adding new dependencies in jdk 11, GC options and few newer APIs changes. (reference : https://gist.github.com/dineshbhagat/97eff450e9edbd7d006deb35f28e3fd4)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2384: Use JDK 11 for Helix Project
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2384:
URL: https://github.com/apache/helix/pull/2384#discussion_r1119550539
##########
.github/workflows/Helix-CI.yml:
##########
@@ -12,14 +12,14 @@ jobs:
steps:
- uses: actions/checkout@v2
- - name: Set up JDK 1.8
+ - name: Set up JDK 11
uses: actions/setup-java@v1
with:
- java-version: 1.8
+ java-version: 11
- name: Build with Maven
- run: mvn clean install -Dmaven.test.skip.exec=true -DretryFailedDeploymentCount=5
Review Comment:
i accidently had removed the modification. re-introduced with latest change
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] desaikomal commented on a diff in pull request #2384: Use JDK 11 for Helix Project
Posted by "desaikomal (via GitHub)" <gi...@apache.org>.
desaikomal commented on code in PR #2384:
URL: https://github.com/apache/helix/pull/2384#discussion_r1120487788
##########
.github/workflows/Helix-PR-CI.yml:
##########
@@ -14,14 +14,14 @@ jobs:
steps:
- uses: actions/checkout@v2
- - name: Set up JDK 1.8
+ - name: Set up JDK 11
uses: actions/setup-java@v1
with:
- java-version: 1.8
+ java-version: 11
- name: Build with Maven
- run: mvn clean install -Dmaven.test.skip.exec=true -DretryFailedDeploymentCount=5
+ run: mvn clean install -Dmaven.test.skip.exec=true
- name: Run All Tests
- run: mvn -q -fae -Dsurefire.rerunFailingTestsCount=5 test
+ run: mvn -q -fae test
Review Comment:
No, it wasn't. I fixed it. thanks for pointing out.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org
[GitHub] [helix] xyuanlu merged pull request #2384: Use JDK 11 for Helix Project
Posted by "xyuanlu (via GitHub)" <gi...@apache.org>.
xyuanlu merged PR #2384:
URL: https://github.com/apache/helix/pull/2384
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@helix.apache.org
For additional commands, e-mail: reviews-help@helix.apache.org