You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@hawq.apache.org by hsyuan <gi...@git.apache.org> on 2016/07/20 21:08:49 UTC
[GitHub] incubator-hawq pull request #806: HAWQ-938. Remove ivy.xml in gpopt and read...
GitHub user hsyuan opened a pull request:
https://github.com/apache/incubator-hawq/pull/806
HAWQ-938. Remove ivy.xml in gpopt and read orca version from header file
The old mechanism extracted the version numbers from the Ivy config file,
which doesn't do the right thing if you build without Ivy. Using the
version headers is simpler, anyway. Also removed `ivy.xml` and `ivy-build.xml`
under `gpopt` folder.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/hsyuan/incubator-hawq HAWQ-938
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/806.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #806
----
commit 2a2a89cc6b950d4067a8e4d8a5e79b2f7b1cf839
Author: Haisheng Yuan <hy...@pivotal.io>
Date: 2016-07-20T20:14:25Z
HAWQ-938. Remove ivy.xml in gpopt and read orca version from header file
The old mechanism extracted the version numbers from the Ivy config file,
which doesn't do the right thing if you build without Ivy. Using the
version headers is simpler, anyway.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/806
pushed to master:
https://github.com/apache/incubator-hawq/commit/78c2766578102501e67c133df942fc6355d56c8e
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request #806: HAWQ-938. Remove ivy.xml in gpopt and read...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan closed the pull request at:
https://github.com/apache/incubator-hawq/pull/806
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...
Posted by changleicn <gi...@git.apache.org>.
Github user changleicn commented on the issue:
https://github.com/apache/incubator-hawq/pull/806
@paul-guo- to review.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/806
Thanks, will take care of it.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...
Posted by paul-guo- <gi...@git.apache.org>.
Github user paul-guo- commented on the issue:
https://github.com/apache/incubator-hawq/pull/806
+1
By the way, I just noticed the following code in gpopt.mk
UNAME = $(shell uname)
UNAME_P = $(shell uname -p)
UNAME_M = $(shell uname -m)
ARCH_OS = GPOS_$(UNAME)
ARCH_CPU = GPOS_$(UNAME_P)
ifeq (Darwin, $(UNAME))
LDSFX = dylib
else
LDSFX = so
endif
Please use DLSUFFIX and PORTNAME which are defined in src/Makefile.global
(and its including makefiles),
and are generated with the configure command. This is another issue, you
could make the change in the future.
2016-07-21 9:21 GMT+08:00 Lei Chang <no...@github.com>:
> @paul-guo- <https://github.com/paul-guo-> to review.
>
> \u2014
> You are receiving this because you were mentioned.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/incubator-hawq/pull/806#issuecomment-234131200>,
> or mute the thread
> <https://github.com/notifications/unsubscribe-auth/AHI5jOKt5ZuX3Q9Uo8NPkj8pX0HtdN4Dks5qXsmegaJpZM4JRNbc>
> .
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq issue #806: HAWQ-938. Remove ivy.xml in gpopt and read orca v...
Posted by hsyuan <gi...@git.apache.org>.
Github user hsyuan commented on the issue:
https://github.com/apache/incubator-hawq/pull/806
@changleicn @yaoj2 @wengyanqing
Please take a look.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---