You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@zookeeper.apache.org by "Mahadev konar (JIRA)" <ji...@apache.org> on 2010/09/15 00:16:35 UTC

[jira] Created: (ZOOKEEPER-870) Zookeeper trunk build broken.

Zookeeper trunk build broken.
-----------------------------

                 Key: ZOOKEEPER-870
                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
             Project: Zookeeper
          Issue Type: Bug
            Reporter: Mahadev konar
            Assignee: Mahadev konar
             Fix For: 3.4.0


the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-870) Zookeeper trunk build broken.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909506#action_12909506 ] 

Mahadev konar commented on ZOOKEEPER-870:
-----------------------------------------

Testcase: testHammer took 81.115 sec
        FAILED
node count not consistent expected:<1771> but was:<0>
junit.framework.AssertionFailedError: node count not consistent expected:<1771> but was:<0>
        at org.apache.zookeeper.test.ClientBase.verifyRootOfAllServersMatch(ClientBase.java:581)
        at org.apache.zookeeper.test.AsyncHammerTest.testHammer(AsyncHammerTest.java:190)
        at org.apache.zookeeper.JUnit4ZKTestRunner$LoggedInvokeMethod.evaluate(JUnit4ZKTestRunner.java:51)


The test case 

junit] Tests run: 2, Failures: 1, Errors: 0, Time elapsed: 107.528 sec
    [junit] Test org.apache.zookeeper.test.NioNettySuiteHammerTest FAILED

also fails.

> Zookeeper trunk build broken.
> -----------------------------
>
>                 Key: ZOOKEEPER-870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.4.0
>
>
> the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-870) Zookeeper trunk build broken.

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Patrick Hunt updated ZOOKEEPER-870:
-----------------------------------

          Status: Resolved  (was: Patch Available)
    Hadoop Flags: [Reviewed]
      Resolution: Fixed

+1 looks ok. pushed to trunk.

> Zookeeper trunk build broken.
> -----------------------------
>
>                 Key: ZOOKEEPER-870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-870.patch, ZOOKEEPER-870.patch
>
>
> the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-870) Zookeeper trunk build broken.

Posted by "Hudson (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909614#action_12909614 ] 

Hudson commented on ZOOKEEPER-870:
----------------------------------

Integrated in ZooKeeper-trunk #936 (See [https://hudson.apache.org/hudson/job/ZooKeeper-trunk/936/])
    ZOOKEEPER-870. Zookeeper trunk build broken.


> Zookeeper trunk build broken.
> -----------------------------
>
>                 Key: ZOOKEEPER-870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-870.patch, ZOOKEEPER-870.patch
>
>
> the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-870) Zookeeper trunk build broken.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-870:
------------------------------------

    Attachment: ZOOKEEPER-870.patch

updated patch with comments incorporated.

> Zookeeper trunk build broken.
> -----------------------------
>
>                 Key: ZOOKEEPER-870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-870.patch, ZOOKEEPER-870.patch
>
>
> the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-870) Zookeeper trunk build broken.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-870:
------------------------------------

    Attachment: ZOOKEEPER-870.patch

This patch ignores the following assertions for now:

- the count of fds in ClienTest
- the count of nodes in ClientBase

These changes will be reverted back in ZOOKEEPER-871 before 3.4 is released. This is just a patch to get the patch process running so that review is done on time.


> Zookeeper trunk build broken.
> -----------------------------
>
>                 Key: ZOOKEEPER-870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-870.patch
>
>
> the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Updated: (ZOOKEEPER-870) Zookeeper trunk build broken.

Posted by "Mahadev konar (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/ZOOKEEPER-870?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated ZOOKEEPER-870:
------------------------------------

    Status: Patch Available  (was: Open)

> Zookeeper trunk build broken.
> -----------------------------
>
>                 Key: ZOOKEEPER-870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-870.patch
>
>
> the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


[jira] Commented: (ZOOKEEPER-870) Zookeeper trunk build broken.

Posted by "Patrick Hunt (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/ZOOKEEPER-870?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12909531#action_12909531 ] 

Patrick Hunt commented on ZOOKEEPER-870:
----------------------------------------

this looks good, however can you make conditional, where the detail is logged at ERROR level if the original assert failed, and at info level otw? you can use LOG.log(priority, msg... ) where priority is a conditional value. then we can more easily identify errors

also, I'd suggest opening another jira for this same release to revert this change at some point. (so we don't forget)

> Zookeeper trunk build broken.
> -----------------------------
>
>                 Key: ZOOKEEPER-870
>                 URL: https://issues.apache.org/jira/browse/ZOOKEEPER-870
>             Project: Zookeeper
>          Issue Type: Bug
>            Reporter: Mahadev konar
>            Assignee: Mahadev konar
>             Fix For: 3.4.0
>
>         Attachments: ZOOKEEPER-870.patch
>
>
> the zookeeper current trunk build is broken mostly due to some netty changes. This is causing a huge backlog of PA's and other impediments to the review process. For now I plan to disable the test and fix them as part of 3.4 later.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.