You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@brooklyn.apache.org by neykov <gi...@git.apache.org> on 2016/11/01 17:14:47 UTC
[GitHub] brooklyn-library pull request #72: Fix test to work on any combination of OS...
GitHub user neykov opened a pull request:
https://github.com/apache/brooklyn-library/pull/72
Fix test to work on any combination of OS & eol type.
Change line endings for generated script as it's most likely to run in a unix environment.
Normalize line endings when comparing scripts to work with any combination of OS & line endings (for tests running on Windows mostly). On Windows you can have both CRLF or LF line endings in the files (or even mixed), depending on how git is configured. That's out of our control so try to support any environment.
The recommended confgiuration is "git --global core.autocrlf true", but Apache Jenkins machines have "core.autocrlf" set to "input". The former will lead to CRLF line endings, the latter to LF line endings on checkout.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/neykov/brooklyn-library fix/windows-eol-test
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/brooklyn-library/pull/72.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #72
----
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #72: Fix test to work on any combination of OS & eol ...
Posted by sjcorbett <gi...@git.apache.org>.
Github user sjcorbett commented on the issue:
https://github.com/apache/brooklyn-library/pull/72
Thanks @neykov and @googlielmo.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #72: Fix test to work on any combination of OS & eol ...
Posted by googlielmo <gi...@git.apache.org>.
Github user googlielmo commented on the issue:
https://github.com/apache/brooklyn-library/pull/72
LGTM
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library issue #72: Fix test to work on any combination of OS & eol ...
Posted by neykov <gi...@git.apache.org>.
Github user neykov commented on the issue:
https://github.com/apache/brooklyn-library/pull/72
/cc @aledsage as discussed a while ago.
The Windows build machines in Apache Infra have been replaced and the new ones set `core.autocrlf=input` globally which results in most files having LF even on Windows. Can't override it per repo, just for our builds.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] brooklyn-library pull request #72: Fix test to work on any combination of OS...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/brooklyn-library/pull/72
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---