You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@kibble.apache.org by GitBox <gi...@apache.org> on 2020/10/27 17:33:53 UTC
[GitHub] [kibble] turbaszek opened a new issue #84: Refactor KibbleDatabase
turbaszek opened a new issue #84:
URL: https://github.com/apache/kibble/issues/84
Currently we implement two times the same class: `KibbleDatabase`:
https://github.com/apache/kibble/blob/2abfcc871dd35ddc727317267a4595f8230b53eb/kibble/setup/makeaccount.py#L27
https://github.com/apache/kibble/blob/2abfcc871dd35ddc727317267a4595f8230b53eb/kibble/api/plugins/database.py#L121
What should be done:
1. We should consolidate the whole logic into single class and create `kibble/database.py` that will keep definition of this object.
2. Refactor this class to use values from `KibbleConfigParser` from `kibble/configuration.py`
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on issue #84: Refactor KibbleDatabase
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #84:
URL: https://github.com/apache/kibble/issues/84#issuecomment-727254412
Additionally when working on #94 I got the following warning. It would be good to address it:
```
/usr/local/lib/python3.8/site-packages/elasticsearch/connection/base.py:190: ElasticsearchDeprecationWarning: [types removal] Specifying types in document index requests is deprecated, use the typeless endpoints instead (/{index}/_doc/{id}, /{index}/_doc, or /{index}/_create/{id}).
warnings.warn(message, category=ElasticsearchDeprecationWarning)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] skekre98 commented on issue #84: Refactor KibbleDatabase
Posted by GitBox <gi...@apache.org>.
skekre98 commented on issue #84:
URL: https://github.com/apache/kibble/issues/84#issuecomment-727268068
Hi @turbaszek, I can take a look into this if it is still available?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] kaxil commented on issue #84: Refactor KibbleDatabase
Posted by GitBox <gi...@apache.org>.
kaxil commented on issue #84:
URL: https://github.com/apache/kibble/issues/84#issuecomment-743996450
Yeah there is lot of duplication which cna be simplified.
Same with yaml file used by scanners to, I think we can unify those configs in the top level .ini file
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on issue #84: Refactor KibbleDatabase
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #84:
URL: https://github.com/apache/kibble/issues/84#issuecomment-743996274
Doing #114 I saw that we have also similar logic of creating es connection in:
https://github.com/apache/kibble/blob/5bf37a8c0db83c918fa476a3a1b653390026e169/kibble/scanners/brokers/kibbleES.py#L286-L298
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [kibble] turbaszek commented on issue #84: Refactor KibbleDatabase
Posted by GitBox <gi...@apache.org>.
turbaszek commented on issue #84:
URL: https://github.com/apache/kibble/issues/84#issuecomment-727273364
@skekre98 sure! I did some changes in #94 around this. However what we need is to:
1. Figure out where we use this class (= where we access the database)
2. Decided what is the best approach to refactor it
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org