You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@arrow.apache.org by "viirya (via GitHub)" <gi...@apache.org> on 2023/06/22 20:41:04 UTC
[GitHub] [arrow-rs] viirya opened a new pull request, #4446: Revise error message in From for ScalaBuffer
viirya opened a new pull request, #4446:
URL: https://github.com/apache/arrow-rs/pull/4446
# Which issue does this PR close?
<!--
We generally require a GitHub issue to be filed for all bug fixes and enhancements and this helps us generate change logs for our releases. You can link an issue to this PR using the GitHub syntax. For example `Closes #123` indicates that this PR will close issue #123.
-->
Related to #4431.
# Rationale for this change
<!--
Why are you proposing this change? If this is already explained clearly in the issue then this section is not needed.
Explaining clearly why changes are proposed helps reviewers understand your changes and offer better suggestions for fixes.
-->
# What changes are included in this PR?
<!--
There is no need to duplicate the description in the issue here but it is sometimes worth providing a summary of the individual changes in this PR.
-->
# Are there any user-facing changes?
<!--
If there are user-facing changes then we may require documentation to be updated before approving the PR.
-->
<!---
If there are any breaking changes to public APIs, please add the `breaking change` label.
-->
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] tustvold commented on a diff in pull request #4446: Revise error message in From for ScalaBuffer
Posted by "tustvold (via GitHub)" <gi...@apache.org>.
tustvold commented on code in PR #4446:
URL: https://github.com/apache/arrow-rs/pull/4446#discussion_r1242051875
##########
arrow-buffer/src/buffer/scalar.rs:
##########
@@ -118,11 +119,16 @@ impl<T: ArrowNativeType> From<MutableBuffer> for ScalarBuffer<T> {
impl<T: ArrowNativeType> From<Buffer> for ScalarBuffer<T> {
fn from(buffer: Buffer) -> Self {
let align = std::mem::align_of::<T>();
- assert_eq!(
- buffer.as_ptr().align_offset(align),
- 0,
- "memory is not aligned"
- );
+ let is_aligned = buffer.as_ptr().align_offset(align) == 0;
+
+ match buffer.deallocation() {
+ Deallocation::Standard(_) => assert!(
+ is_aligned,
+ "Memory pointer is not aligned with the specified scalar type."
Review Comment:
```suggestion
"Memory pointer is not aligned with the specified scalar type"
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya commented on a diff in pull request #4446: Revise error message in From for ScalaBuffer
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya commented on code in PR #4446:
URL: https://github.com/apache/arrow-rs/pull/4446#discussion_r1239011698
##########
arrow-buffer/src/buffer/scalar.rs:
##########
@@ -118,11 +119,16 @@ impl<T: ArrowNativeType> From<MutableBuffer> for ScalarBuffer<T> {
impl<T: ArrowNativeType> From<Buffer> for ScalarBuffer<T> {
fn from(buffer: Buffer) -> Self {
let align = std::mem::align_of::<T>();
- assert_eq!(
- buffer.as_ptr().align_offset(align),
- 0,
- "memory is not aligned"
- );
+ let is_aligned = buffer.as_ptr().align_offset(align) == 0;
+
+ match buffer.deallocation() {
+ Deallocation::Standard(_) => assert!(
+ is_aligned,
+ "Memory pointer is not aligned with the specified scalar type."
+ ),
+ Deallocation::Custom(_) =>
+ assert!(is_aligned, "Memory pointer from external source (e.g, FFI) is not aligned with the specified scalar type. Before importing buffer through FFI, please make sure the allocation is aligned."),
Review Comment:
This is to clarify the error message for users who don't know too much details about the implementation.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [arrow-rs] viirya merged pull request #4446: Revise error message in From for ScalarBuffer
Posted by "viirya (via GitHub)" <gi...@apache.org>.
viirya merged PR #4446:
URL: https://github.com/apache/arrow-rs/pull/4446
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@arrow.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org