You are viewing a plain text version of this content. The canonical link for it is here.
Posted to github@beam.apache.org by "liferoad (via GitHub)" <gi...@apache.org> on 2026/03/14 00:04:43 UTC
[PR] Fix #37833: Use named logger instead of root logger in transforms/util.py [beam]
liferoad opened a new pull request, #37857:
URL: https://github.com/apache/beam/pull/37857
## What
Fixes https://github.com/apache/beam/issues/37833
`apache_beam.transforms.util` was using the root logger (`logging.info(...)`, `logging.warning(...)`, etc.) instead of a module-level named logger. This prevented `sdk_harness_log_level_overrides` from controlling log levels for this module (e.g., suppressing the verbose `BatchElements statistics` message at line 1029).
## Changes
- Added `_LOGGER = logging.getLogger(__name__)` after imports
- Replaced all 8 root logger calls with `_LOGGER` calls
This is consistent with other modules like `apache_beam.transforms.core` which already use `_LOGGER = logging.getLogger(__name__)`.
## How it was tested
Minimal change — only replaces the logger object used. No behavioral change unless `sdk_harness_log_level_overrides` is configured, in which case named logger overrides will now correctly apply to `apache_beam.transforms.util`.
---
Thank you for your contribution! Follow this checklist to help us incorporate your contribution quickly and easily:
- [x] Addresses an existing issue: https://github.com/apache/beam/issues/37833
- [x] Includes tests (not needed — no logic change)
- [x] Updates documentation (not needed)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #37833: Use named logger instead of root logger in transforms/util.py [beam]
Posted by "gemini-code-assist[bot] (via GitHub)" <gi...@apache.org>.
gemini-code-assist[bot] commented on PR #37857:
URL: https://github.com/apache/beam/pull/37857#issuecomment-4058826022
## Summary of Changes
Hello, I'm Gemini Code Assist[^1]! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!
This pull request refactors the logging implementation within `apache_beam.transforms.util` to utilize a named logger instead of the root logger. This change is crucial for allowing external configurations, such as `sdk_harness_log_level_overrides`, to effectively control the verbosity of logs originating from this module, thereby improving log management and debugging capabilities.
### Highlights
* **Logging Mechanism**: Switched `apache_beam.transforms.util` from using the global root logger to a dedicated module-level named logger.
* **Log Level Control**: Enabled `sdk_harness_log_level_overrides` to properly manage log levels for this module, addressing an issue where verbose messages could not be suppressed.
* **Code Consistency**: Aligned logging practices in `apache_beam.transforms.util` with other modules like `apache_beam.transforms.core` for better consistency.
🧠 **New Feature in Public Preview:** You can now enable **Memory** to help **Gemini Code Assist** learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. **Click [here](https://codeassist.google/code-review/login) to enable Memory in your admin console.**
<details>
<summary><b>Changelog</b></summary>
* **sdks/python/apache_beam/transforms/util.py**
* Added a module-level named logger `_LOGGER`.
* Replaced all instances of `logging.info`, `logging.warning`, `logging.debug`, `logging.error`, and `logging.critical` with their `_LOGGER` equivalents.
</details>
<details>
<summary><b>Activity</b></summary>
* Addressed issue #37833.
* Confirmed that tests are not needed due to no logic change.
* Confirmed that documentation updates are not needed.
</details>
<details>
<summary><b>Using Gemini Code Assist</b></summary>
<br>
The full guide for Gemini Code Assist can be found on our [documentation page](https://developers.google.com/gemini-code-assist/docs/review-github-code), here are some quick tips.
<b>Invoking Gemini</b>
You can request assistance from Gemini at any point by creating a comment using either `/gemini <command>` or `@gemini-code-assist <command>`. Below is a summary of the supported commands on the current page.
Feature | Command | Description
--- | --- | ---
Code Review | `/gemini review` | Performs a code review for the current pull request in its current state.
Pull Request Summary | `/gemini summary` | Provides a summary of the current pull request in its current state.
Comment | @gemini-code-assist | Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help | `/gemini help` | Displays a list of available commands.
<b>Customization</b>
To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a `.gemini/` folder in the base of the repository. Detailed instructions can be found [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github).
<b>Limitations & Feedback</b>
Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with :thumbsup: and :thumbsdown: on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up [here](https://google.qualtrics.com/jfe/form/SV_2cyuGuTWsEw84yG).
<b>You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the [Gemini Code Assist IDE Extension](https://cloud.google.com/products/gemini/code-assist).</b>
</details>
[^1]: Review the [Privacy Notices](https://policies.google.com/privacy), [Generative AI Prohibited Use Policy](https://policies.google.com/terms/generative-ai/use-policy), [Terms of Service](https://policies.google.com/terms), and learn how to configure Gemini Code Assist in GitHub [here](https://developers.google.com/gemini-code-assist/docs/customize-gemini-behavior-github). Gemini can make mistakes, so double check it and [use code with caution](https://support.google.com/legal/answer/13505487).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #37833: Use named logger instead of root logger in transforms/util.py [beam]
Posted by "liferoad (via GitHub)" <gi...@apache.org>.
liferoad merged PR #37857:
URL: https://github.com/apache/beam/pull/37857
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
Re: [PR] Fix #37833: Use named logger instead of root logger in transforms/util.py [beam]
Posted by "github-actions[bot] (via GitHub)" <gi...@apache.org>.
github-actions[bot] commented on PR #37857:
URL: https://github.com/apache/beam/pull/37857#issuecomment-4059105047
Assigning reviewers:
R: @damccorm for label python.
Note: If you would like to opt out of this review, comment `assign to next reviewer`.
Available commands:
- `stop reviewer notifications` - opt out of the automated review tooling
- `remind me after tests pass` - tag the comment author after tests pass
- `waiting on author` - shift the attention set back to the author (any comment or push by the author will return the attention set to the reviewers)
The PR bot will only process comments in the main thread (not review comments).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: github-unsubscribe@beam.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org