You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Jie Yu <yu...@gmail.com> on 2014/05/22 20:49:19 UTC
Review Request 21823: Returned false in link::remove() if NLE_NODEV is
received.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21823/
-----------------------------------------------------------
Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
Repository: mesos-git
Description
-------
See summary.
Diffs
-----
src/linux/routing/link/link.cpp 039e308
Diff: https://reviews.apache.org/r/21823/diff/
Testing
-------
make check
Thanks,
Jie Yu
Re: Review Request 21823: Returned false in link::remove() if NLE_NODEV is
received.
Posted by Chi Zhang <ch...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21823/#review43754
-----------------------------------------------------------
Ship it!
src/linux/routing/link/link.cpp
<https://reviews.apache.org/r/21823/#comment78039>
i think a comment would be nice. link could removed after line 96 but before 108, which could cause NLE_NODEV
- Chi Zhang
On May 22, 2014, 6:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21823/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 6:49 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/link/link.cpp 039e308
>
> Diff: https://reviews.apache.org/r/21823/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>
Re: Review Request 21823: Returned false in link::remove() if NLE_NODEV is
received.
Posted by Vinod Kone <vi...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/21823/#review43851
-----------------------------------------------------------
Ship it!
Ship It!
- Vinod Kone
On May 22, 2014, 6:49 p.m., Jie Yu wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/21823/
> -----------------------------------------------------------
>
> (Updated May 22, 2014, 6:49 p.m.)
>
>
> Review request for mesos, Chi Zhang, Ian Downes, Vinod Kone, and Cong Wang.
>
>
> Repository: mesos-git
>
>
> Description
> -------
>
> See summary.
>
>
> Diffs
> -----
>
> src/linux/routing/link/link.cpp 039e308
>
> Diff: https://reviews.apache.org/r/21823/diff/
>
>
> Testing
> -------
>
> make check
>
>
> Thanks,
>
> Jie Yu
>
>