[jira] [Commented] (MESOS-5600) "dirty" was never set back as false in sorter

["Guangya Liu (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/MESOS-5600?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15325648#comment-15325648 ] 

Guangya Liu commented on MESOS-5600:
------------------------------------

[~bmahler] compared with move the false initialization into the initializer list, I prefer we keep current logic by initializing the {{dirty}} in sorter.hpp. 

My thinking is that if we move the false initialization into the initializer list, then I may need to add a new constructor for sorter() to initialize dirty and update all initialize code when create the sorters, this will involve many code change, but the current initialize logic is simple and easy to understand. Comments?

> "dirty" was never set back as false in sorter
> ---------------------------------------------
>
>                 Key: MESOS-5600
>                 URL: https://issues.apache.org/jira/browse/MESOS-5600
>             Project: Mesos
>          Issue Type: Bug
>          Components: allocation
>            Reporter: Guangya Liu
>            Assignee: Guangya Liu
>
> dirty was set as true when the total resource was updated in the cluster, but it was never set back as false. The dirty should be set back as false in DRFSorter::sort https://github.com/apache/mesos/blob/master/src/master/allocator/sorter/drf/sorter.cpp#L320-L334
> The reason that we cannot detect this is because once an agent was added to cluster, the dirty will be set as true and the sorter will always call sort() to calculate share for each framework, this will impact the performance.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)