[GitHub] [flink] xuefuz commented on a change in pull request #8882: [FLINK-12965][table][hive] unify catalog view implementations

[GitBox <gi...@apache.org>]

xuefuz commented on a change in pull request #8882: [FLINK-12965][table][hive] unify catalog view implementations
URL: https://github.com/apache/flink/pull/8882#discussion_r297481016
 
 

 ##########
 File path: flink-table/flink-table-api-java/src/main/java/org/apache/flink/table/catalog/QueryOperationCatalogView.java
 ##########
 @@ -28,7 +28,7 @@
  * A view created from a {@link QueryOperation} via operations on {@link org.apache.flink.table.api.Table}.
  */
 @Internal
-public class QueryOperationCatalogView extends AbstractCatalogView {
+public class QueryOperationCatalogView extends CatalogViewImpl {
 
 Review comment:
   Previously QueryOperationCatalogView, HiveCatalogView, and GenericCatalogView were children of AbstractCatalogView. Now we combine the latter two, and make the first one as a child of the combo, which might be a concern. I'm not sure if this posts any issue, but maybe we can keep the relationship unchanged?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services