You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@mesos.apache.org by Till Toenshoff <to...@me.com> on 2014/04/29 02:05:38 UTC

Review Request 20819: Fixed incorrect invocation of the mesos-executor within test_containerizer.py.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20819/
-----------------------------------------------------------

Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Repository: mesos-git


Description
-------

see subject. 


Diffs
-----

  src/examples/python/test_containerizer.py 57b4bb6 

Diff: https://reviews.apache.org/r/20819/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 20819: Fixed incorrect invocation of the mesos-executor within test_containerizer.py.

Posted by Till Toenshoff <to...@me.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20819/
-----------------------------------------------------------

(Updated April 29, 2014, 12:16 a.m.)


Review request for mesos, Benjamin Hindman and Niklas Nielsen.


Changes
-------

Updated description to give a bit more context.


Repository: mesos-git


Description (updated)
-------

The incorrect invocation of the mesos-containerizer would possibly trigger problems. This should get rid of failures where the slave runs into a timeout when waiting for the executor registration on  ExternalContainerizerTest.Launch. See https://builds.apache.org/job/Mesos-Trunk-Ubuntu-Build-Out-Of-Src-Set-JAVA_HOME/2096/consoleFull for such scenario.


Diffs
-----

  src/examples/python/test_containerizer.py 57b4bb6 

Diff: https://reviews.apache.org/r/20819/diff/


Testing
-------

make check


Thanks,

Till Toenshoff


Re: Review Request 20819: Fixed incorrect invocation of the mesos-executor within test_containerizer.py.

Posted by Niklas Nielsen <ni...@qni.dk>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/20819/#review41650
-----------------------------------------------------------

Ship it!


Thanks Till! I will get this committed today.

- Niklas Nielsen


On April 28, 2014, 5:05 p.m., Till Toenshoff wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/20819/
> -----------------------------------------------------------
> 
> (Updated April 28, 2014, 5:05 p.m.)
> 
> 
> Review request for mesos, Benjamin Hindman and Niklas Nielsen.
> 
> 
> Repository: mesos-git
> 
> 
> Description
> -------
> 
> see subject. 
> 
> 
> Diffs
> -----
> 
>   src/examples/python/test_containerizer.py 57b4bb6 
> 
> Diff: https://reviews.apache.org/r/20819/diff/
> 
> 
> Testing
> -------
> 
> make check
> 
> 
> Thanks,
> 
> Till Toenshoff
> 
>