You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@mesos.apache.org by Timothy Chen <tn...@apache.org> on 2015/07/01 00:37:35 UTC
Re: Review Request 34137: Add support for container image
provisioners.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/34137/#review89975
-----------------------------------------------------------
src/slave/containerizer/mesos/containerizer.cpp (line 626)
<https://reviews.apache.org/r/34137/#comment142882>
I think we should include the type in the failure message too.
src/slave/containerizer/mesos/containerizer.cpp (line 1247)
<https://reviews.apache.org/r/34137/#comment142883>
Include the type in the warning message so it's easier to debug.
- Timothy Chen
On June 22, 2015, 4:44 p.m., Ian Downes wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/34137/
> -----------------------------------------------------------
>
> (Updated June 22, 2015, 4:44 p.m.)
>
>
> Review request for mesos, Chi Zhang, Paul Brett, Timothy Chen, and Vinod Kone.
>
>
> Repository: mesos
>
>
> Description
> -------
>
> The MesosContainerizer can optionally provision a root filesystem for the containers.
>
>
> Diffs
> -----
>
> include/mesos/slave/isolator.hpp 18edc030367e42240090f2f3dbc92aec7a4c6234
> src/Makefile.am e7de0f3d1a5efeaef47d5074defe3b40db94f573
> src/slave/containerizer/mesos/containerizer.hpp 3ac2387eabded61c897a5016655aae10cd1bca91
> src/slave/containerizer/mesos/containerizer.cpp 8c102fb7d1f79ee768cb06de3a976ea12f958712
> src/slave/containerizer/provisioner.hpp PRE-CREATION
> src/slave/containerizer/provisioner.cpp PRE-CREATION
> src/slave/flags.hpp 7634e368c72e83932dcd992d78eaca146326606b
> src/slave/flags.cpp cbf431eb0627bdaf07241cc0fc4630df06fb20e2
> src/slave/paths.hpp 00476f107ed8233123a6eab0925c9f28aac0a86f
> src/slave/paths.cpp 0741616b656e947cb460dd6ee6a9a4852be001c2
> src/slave/state.hpp fed4b7ecf9572a8dbb1a99dbb1769d3e55ef7bc5
> src/slave/state.cpp 8eda22a550e5add0f84c46cc2ed762b006c0dcec
> src/tests/containerizer_tests.cpp 0cdb2d2a3f19a4835e85c6b040759019b03f051e
>
> Diff: https://reviews.apache.org/r/34137/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Ian Downes
>
>